Throw when initialize has not been called

change/@azure-msal-browser-ab1ea9b9-384d-4109-99f6-e7546d4103ee.json

@@ -0,0 +1,7 @@
+{
+  "type": "prerelease",
+  "comment": "Throw when initialize has not been called #6233",
+  "packageName": "@azure/msal-browser",
+  "email": "[email protected]",
+  "dependentChangeType": "patch"
+}

change/@azure-msal-react-19531516-0c61-4562-8efe-b90118d50341.json

@@ -0,0 +1,7 @@
+{
+  "type": "none",
+  "comment": "Throw when initialize has not been called #6233",
+  "packageName": "@azure/msal-react",
+  "email": "[email protected]",
+  "dependentChangeType": "none"
+}

lib/msal-browser/src/controllers/StandardController.ts

@@ -25,7 +25,7 @@ import {
     RequestThumbprint,
     ServerError,
     ServerResponseType,
-    UrlString
+    UrlString,
 } from "@azure/msal-common";
 import {
     BrowserCacheManager,
@@ -320,15 +320,15 @@ export class StandardController implements IController {
         hash?: string
     ): Promise<AuthenticationResult | null> {
         this.logger.verbose("handleRedirectPromise called");
-        // Block token acquisition before initialize has been called if native brokering is enabled
-        BrowserUtils.blockNativeBrokerCalledBeforeInitialized(
-            this.config.system.allowNativeBroker,
-            this.initialized
-        );
+        // Block token acquisition before initialize has been called
+        BrowserUtils.blockAPICallsBeforeInitialize(this.initialized);
 
         let foundServerResponse = hash;
-
-        if(this.config.auth.OIDCOptions?.serverResponseType === ServerResponseType.QUERY) {
+
+        if (
+            this.config.auth.OIDCOptions?.serverResponseType ===
+            ServerResponseType.QUERY
+        ) {
             const url = window.location.href;
             foundServerResponse = UrlString.parseQueryServerResponse(url);
         }
@@ -340,7 +340,8 @@ export class StandardController implements IController {
              * otherwise return the promise from the first invocation. Prevents race conditions when handleRedirectPromise is called
              * several times concurrently.
              */
-            const redirectResponseKey = foundServerResponse || Constants.EMPTY_STRING;
+            const redirectResponseKey =
+                foundServerResponse || Constants.EMPTY_STRING;
             let response = this.redirectResponse.get(redirectResponseKey);
             if (typeof response === "undefined") {
                 this.eventHandler.emitEvent(
@@ -394,7 +395,9 @@ export class StandardController implements IController {
                     const redirectClient =
                         this.createRedirectClient(correlationId);
                     redirectResponse =
-                        redirectClient.handleRedirectPromise(foundServerResponse);
+                        redirectClient.handleRedirectPromise(
+                            foundServerResponse
+                        );
                 }
 
                 response = redirectResponse
@@ -1306,16 +1309,8 @@ export class StandardController implements IController {
         // Block redirectUri opened in a popup from calling MSAL APIs
         BrowserUtils.blockAcquireTokenInPopups();
 
-        /*
-         * Block token acquisition before initialize has been called if native brokering is enabled in top-frame.
-         * Skip check if application is embedded.
-         */
-        if (!isAppEmbedded) {
-            BrowserUtils.blockNativeBrokerCalledBeforeInitialized(
-                this.config.system.allowNativeBroker,
-                this.initialized
-            );
-        }
+        // Block token acquisition before initialize has been called
+        BrowserUtils.blockAPICallsBeforeInitialize(this.initialized);
 
         // Block redirects if memory storage is enabled but storeAuthStateInCookie is not
         if (

lib/msal-browser/src/error/BrowserAuthError.ts

@@ -181,9 +181,9 @@ export const BrowserAuthErrorMessage = {
         code: "native_connection_not_established",
         desc: "Connection to native platform has not been established. Please install a compatible browser extension and run initialize(). For more please visit aka.ms/msaljs/browser-errors.",
     },
-    nativeBrokerCalledBeforeInitialize: {
-        code: "native_broker_called_before_initialize",
-        desc: "You must call and await the initialize function before attempting to call any other MSAL API when native brokering is enabled. For more please visit aka.ms/msaljs/browser-errors.",
+    uninitializedPublicClientApplication: {
+        code: "uninitialized_public_client_application",
+        desc: "You must call and await the initialize function before attempting to call any other MSAL API. For more please visit aka.ms/msaljs/browser-errors.",
     },
     nativePromptNotSupported: {
         code: "native_prompt_not_supported",
@@ -672,10 +672,10 @@ export class BrowserAuthError extends AuthError {
     /**
      * Create an error thrown when the initialize function hasn't been called
      */
-    static createNativeBrokerCalledBeforeInitialize(): BrowserAuthError {
+    static createUninitializedPublicClientApplication(): BrowserAuthError {
         return new BrowserAuthError(
-            BrowserAuthErrorMessage.nativeBrokerCalledBeforeInitialize.code,
-            BrowserAuthErrorMessage.nativeBrokerCalledBeforeInitialize.desc
+            BrowserAuthErrorMessage.uninitializedPublicClientApplication.code,
+            BrowserAuthErrorMessage.uninitializedPublicClientApplication.desc
         );
     }
 

lib/msal-browser/src/utils/BrowserUtils.ts

@@ -146,16 +146,12 @@ export class BrowserUtils {
     }
 
     /**
-     * Throws error if native brokering is enabled but initialize hasn't been called
-     * @param allowNativeBroker
+     * Throws error if initialize hasn't been called
      * @param initialized
      */
-    static blockNativeBrokerCalledBeforeInitialized(
-        allowNativeBroker: boolean,
-        initialized: boolean
-    ): void {
-        if (allowNativeBroker && !initialized) {
-            throw BrowserAuthError.createNativeBrokerCalledBeforeInitialize();
+    static blockAPICallsBeforeInitialize(initialized: boolean): void {
+        if (!initialized) {
+            throw BrowserAuthError.createUninitializedPublicClientApplication();
         }
     }
 

lib/msal-browser/test/app/PCANonBrowser.spec.ts

@@ -136,24 +136,24 @@ describe("Non-browser environment", () => {
         });
     });
 
-    it("getAllAccounts returns empty array", () => {
+    it("getAllAccounts returns empty array", async () => {
         const instance = new PublicClientApplication({
             auth: {
                 clientId: TEST_CONFIG.MSAL_CLIENT_ID,
             },
         });
-
+        await instance.initialize();
         const accounts = instance.getAllAccounts();
         expect(accounts).toEqual([]);
     });
 
-    it("getAccountByUsername returns null", () => {
+    it("getAccountByUsername returns null", async () => {
         const instance = new PublicClientApplication({
             auth: {
                 clientId: TEST_CONFIG.MSAL_CLIENT_ID,
             },
         });
-
+        await instance.initialize();
         const account = instance.getAccountByUsername("[email protected]");
         expect(account).toEqual(null);
     });
@@ -167,10 +167,11 @@ describe("Non-browser environment", () => {
                 allowNativeBroker: false,
             },
         });
-
-        instance.handleRedirectPromise().then((result) => {
-            expect(result).toBeNull();
-            done();
+        instance.initialize().then(() => {
+            instance.handleRedirectPromise().then((result) => {
+                expect(result).toBeNull();
+                done();
+            });
         });
     });