Throw when initialize has not been called

[hectormmg]

This PR:

• Replaces BrowserUtils.blockNativeBrokerCalledBeforeInitialize with BrowserUtils.blockCallsBeforeInitialize since now initialize call is required regardless of whether allowNativeBroker is enabled
• Calls BrowserUtils.blockCallsBeforeInitialize in all public APIs related to token acquisition and accounts
• Replaces BrowserAuthError.createNativeBrokerCalledBeforeInitialize() with BrowserAuthError.createUninitializedPublicClientApplication() and updates error message
• Updates browser spec files to match new behavior

[codecov-commenter]

Codecov Report

Merging #6233 (bce4fb2) into dev (81d34b4) will increase coverage by 1.78%.
Report is 217 commits behind head on dev.
The diff coverage is 96.63%.

Flag	Coverage Δ
msal-angular	96.73% <96.63%> (+0.22%)	⬆️
msal-browser	85.66% <ø> (-0.81%)	⬇️
msal-common	?
msal-core	?
msal-node	?
msal-node-extensions	?
msal-react	94.24% <ø> (-0.45%)	⬇️
node-token-validation	?

Files Changed	Coverage Δ
...b/msal-browser/src/app/IPublicClientApplication.ts	43.75% <ø> (ø)
...ib/msal-browser/src/app/PublicClientApplication.ts	66.66% <ø> (-28.67%)	⬇️
...er/src/broker/nativeBroker/NativeMessageHandler.ts	86.29% <ø> (+0.33%)	⬆️
lib/msal-browser/src/cache/AsyncMemoryStorage.ts	80.76% <ø> (+2.99%)	⬆️
lib/msal-browser/src/cache/BrowserCacheManager.ts	90.18% <ø> (-1.54%)	⬇️
lib/msal-browser/src/cache/BrowserStorage.ts	87.50% <ø> (-3.41%)	⬇️
lib/msal-browser/src/cache/CryptoKeyStore.ts	80.00% <ø> (-3.34%)	⬇️
lib/msal-browser/src/cache/DatabaseStorage.ts	34.00% <ø> (-4.54%)	⬇️
lib/msal-browser/src/cache/MemoryStorage.ts	100.00% <ø> (ø)
lib/msal-browser/src/cache/TokenCache.ts	85.86% <ø> (+4.86%)	⬆️
... and 56 more

... and 168 files with indirect coverage changes

[tnorling]

Looks good besides one minor comment, thanks for this!

[sameerag]

Can we not initialize ourselves by default instead of adding this check at a zillion places?

[sameerag]

Can we sync up once before I approve this on why we chose not to initialize ourselves or if there is a better way to do this?

[hectormmg]

Can we sync up once before I approve this on why we chose not to initialize ourselves or if there is a better way to do this?

There's not much we can do since initialize is async. We need these checks because someone could instantiate a PCA and start calling APIs without initializing.

[sameerag]

As discussed, approving with suggestions to improve on this for the next major version. Also:
nit: Can we rename the function name to blockAPICallsBeforeInitialize()?

[shoatman]

lgtm