Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove faulting property location from azapi_resource #1053

Merged
merged 3 commits into from
Aug 29, 2024

Conversation

SvenAelterman
Copy link
Contributor

@SvenAelterman SvenAelterman commented Jul 24, 2024

Overview/Summary

Corrects the property bag for the azapi_resource that creates diagnostic settings on management groups. It doesn't support a location property.

This PR fixes/adds/changes/removes

  1. Bug Report: deploy_diagnostics_for_mg generates invalid az_api call #1052

Breaking Changes

N/A

Testing Evidence

N/A

As part of this Pull Request I have

  • Checked for duplicate Pull Requests
  • Associated it with relevant issues, for tracking and closure.
  • Ensured my code/branch is up-to-date with the latest changes in the main branch
  • Performed testing and provided evidence.
  • Updated relevant and associated documentation.

@SvenAelterman
Copy link
Contributor Author

This might also finally close #672 ?

@roddick-mark
Copy link

please can this be merged? also facing this issue

@matt-FFFFFF
Copy link
Member

/azp run unit

Copy link

Azure Pipelines successfully started running 1 pipeline(s).

@matt-FFFFFF
Copy link
Member

/azp run unit

Copy link

Azure Pipelines successfully started running 1 pipeline(s).

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants