Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Bug Report: deploy_diagnostics_for_mg generates invalid az_api call #1052

Closed
SvenAelterman opened this issue Jul 24, 2024 · 1 comment
Closed

Bug Report: deploy_diagnostics_for_mg generates invalid az_api call #1052

SvenAelterman opened this issue Jul 24, 2024 · 1 comment

Comments

@SvenAelterman
Copy link
Contributor

Community Note

  • Please vote on this issue by adding a 👍 reaction to the original issue to help the community and maintainers prioritize this request
  • Please do not leave "+1" or "me too" comments, they generate extra noise for issue followers and do not help prioritize the request
  • If you are interested in working on this issue or have submitted a pull request, please leave a comment

Versions

terraform: 1.9.2

azure provider: 3.113.0

module: 6.0.0

Description

Describe the bug

When setting deploy_diagnostics_for_mg to true, it uses resources_management_groups.tf:85, which attempts to set a location property which doesn't exist.

Steps to Reproduce

  1. Set deploy_diagnostics_for_mg to true
@SvenAelterman SvenAelterman mentioned this issue Jul 24, 2024
Merged
5 tasks
matt-FFFFFF added a commit that referenced this issue Aug 29, 2024
@SvenAelterman @matt-FFFFFF
Remove faulting property location from azapi_resource (#1053)
ea21355 
<!-- markdownlint-disable first-line-h1 -->

## Overview/Summary

Corrects the property bag for the azapi_resource that creates diagnostic
settings on management groups. It doesn't support a `location` property.

## This PR fixes/adds/changes/removes

1. #1052 

### Breaking Changes

N/A

## Testing Evidence

N/A

## As part of this Pull Request I have

- [x] Checked for duplicate [Pull
Requests](https://github.com/Azure/terraform-azurerm-caf-enterprise-scale/pulls)
- [x] Associated it with relevant
[issues](https://github.com/Azure/terraform-azurerm-caf-enterprise-scale/issues),
for tracking and closure.
- [x] Ensured my code/branch is up-to-date with the latest changes in
the `main`
[branch](https://github.com/Azure/terraform-azurerm-caf-enterprise-scale/tree/main)
- [x] Performed testing and provided evidence.
- [ ] Updated relevant and associated documentation.

Co-authored-by: Matt White <[email protected]>
@matt-FFFFFF
Copy link
Member

closed by #1053

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@matt-FFFFFF @SvenAelterman