Allow passing schemaUrl to tracer and meter provider, separate sdk options to a new class #41789
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
Azure.Core
lmolkova
force-pushed
the
otel-pass-schema-url
branch
3 times, most recently
from
5e93d11
to
838c33e
Compare
lmolkova
requested review from
trask,
alzimmermsft,
srnagar,
anuchandy,
vcolin7,
mssfang,
JonathanGiles and
billwert
as code owners
|
API change check APIView has identified API level changes in this PR and created following API reviews. com.azure:azure-core-metrics-opentelemetry |
trask
approved these changes
Sep 23, 2024
...emetry/src/samples/java/com/azure/core/metrics/opentelemetry/MetricsJavaDocCodeSnippets.java
Outdated
Show resolved
Hide resolved
...rc/samples/java/com/azure/core/tracing/opentelemetry/samples/TracingJavaDocCodeSnippets.java
Outdated
Show resolved
Hide resolved
...ics-opentelemetry/src/main/java/com/azure/core/metrics/opentelemetry/OpenTelemetryMeter.java
Show resolved
Hide resolved
...elemetry/src/main/java/com/azure/core/tracing/opentelemetry/OpenTelemetryTracerProvider.java
Show resolved
Hide resolved
sdk/core/azure-core/src/main/java/com/azure/core/util/LibraryTelemetryOptions.java
Show resolved
Hide resolved
lmolkova
force-pushed
the
otel-pass-schema-url
branch
from
483c60d
to
b7c9d90
Compare
lmolkova
force-pushed
the
otel-pass-schema-url
branch
from
b7c9d90
to
1ad0e07
Compare
alzimmermsft
approved these changes
Sep 24, 2024
srnagar
approved these changes
Sep 24, 2024
...elemetry/src/main/java/com/azure/core/tracing/opentelemetry/OpenTelemetryTracerProvider.java
Outdated
Show resolved
Hide resolved
mssfang
pushed a commit
to mssfang/azure-sdk-for-java
that referenced
this pull request
Oct 21, 2024
…tions to a new class (Azure#41789) * Allow passing schemaUrl to tracer and meter provider, separate sdk options to a new class
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix #41485