B

code review
Azure · Sep 24, 2024 · 1ad0e07 · 1ad0e07
1 parent cf09414
commit 1ad0e07
Show file tree

Hide file tree

Showing 3 changed files with 7 additions and 0 deletions.
diff --git a/...emetry/src/main/java/com/azure/core/metrics/opentelemetry/OpenTelemetryMeterProvider.java b/...emetry/src/main/java/com/azure/core/metrics/opentelemetry/OpenTelemetryMeterProvider.java
@@ -127,6 +127,8 @@ public Meter createMeter(String libraryName, String libraryVersion, MetricsOptio
     @Override
     public Meter createMeter(LibraryTelemetryOptions libraryOptions, MetricsOptions applicationOptions) {
         Objects.requireNonNull(libraryOptions, "'libraryOptions' cannot be null.");
+        Objects.requireNonNull(libraryOptions.getLibraryName(), "'libraryOptions.getLibraryName()' cannot be null.");
+
         return new OpenTelemetryMeter(libraryOptions, applicationOptions);
     }
 }
diff --git a/...metry/src/main/java/com/azure/core/tracing/opentelemetry/OpenTelemetryTracerProvider.java b/...metry/src/main/java/com/azure/core/tracing/opentelemetry/OpenTelemetryTracerProvider.java
@@ -53,6 +53,9 @@ public Tracer createTracer(String libraryName, String libraryVersion, String azN
      */
     @Override
     public Tracer createTracer(LibraryTelemetryOptions libraryOptions, TracingOptions applicationOptions) {
+        Objects.requireNonNull(libraryOptions, "'libraryOptions' cannot be null.");
+        Objects.requireNonNull(libraryOptions.getLibraryName(), "'libraryOptions.getLibraryName()' cannot be null.");
+
         return new OpenTelemetryTracer(libraryOptions, applicationOptions);
     }
 }
diff --git a/sdk/core/azure-core/src/main/java/com/azure/core/util/LibraryTelemetryOptions.java b/sdk/core/azure-core/src/main/java/com/azure/core/util/LibraryTelemetryOptions.java
@@ -4,10 +4,12 @@
 package com.azure.core.util;
 
 import com.azure.core.annotation.Fluent;
+import com.azure.core.util.metrics.MeterProvider;
 import com.azure.core.util.tracing.TracerProvider;
 
 /**
  * The options to configure library-specific information on {@link TracerProvider}
+ * and {@link MeterProvider}.
  */
 @Fluent
 public final class LibraryTelemetryOptions {