Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Dev alz pattern #314

Open
wants to merge 26 commits into
base: main
Choose a base branch
from
Open
Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
26 commits
Select commit Hold shift + click to select a range
13bc071
Updating json template
ymehdimsft Aug 1, 2024
ade3104
Updating json file
ymehdimsft Aug 1, 2024
38e4e45
Merge branch 'Azure:dev-alz-pattern' into dev-alz-pattern
ymehdimsft Aug 1, 2024
041829e
Updates for Alerts
ymehdimsft Aug 2, 2024
6878263
Merge branch 'dev-alz-pattern' of https://github.com/ymehdimsft/azure…
ymehdimsft Aug 2, 2024
2e34684
Updates on policies bicep files
ymehdimsft Aug 2, 2024
fcc492a
Updates for bicep policies
ymehdimsft Aug 2, 2024
b555daf
Updates on bicep policies files
ymehdimsft Aug 2, 2024
2a92f74
Updates
ymehdimsft Aug 2, 2024
25a373b
More updates
ymehdimsft Aug 2, 2024
3ba4e2b
Updates
ymehdimsft Aug 2, 2024
b439c8b
Updates App Insights Delete Alert
ymehdimsft Aug 2, 2024
34ca13c
Updates code AppI delete
ymehdimsft Aug 2, 2024
a30815e
Update Deploy-AppInsightsThrottlingLimit-Alert.json
Brunoga-MS Aug 27, 2024
78dacb9
Update Deploy-ActivityLog-AppInsights-Del.json
Brunoga-MS Aug 27, 2024
370127c
Merge pull request #2 from Brunoga-MS/patch-2
ymehdimsft Aug 27, 2024
1d23328
Merge pull request #1 from Brunoga-MS/patch-3
ymehdimsft Aug 27, 2024
4ff546e
Update Deploy-AppInsightsThrottlingLimit-Alert.json
Brunoga-MS Aug 27, 2024
846c998
Update Deploy-AppInsightsThrottlingLimit-Alert.json
Brunoga-MS Aug 27, 2024
6b760d7
Merge pull request #3 from Brunoga-MS/patch-4
ymehdimsft Aug 28, 2024
98a5e0e
Update Deploy-AppInsightsThrottlingLimit-Alert.json
Brunoga-MS Aug 28, 2024
1b4ba57
Merge pull request #4 from Brunoga-MS/patch-5
ymehdimsft Aug 28, 2024
ed43c84
Merge branch 'Azure:dev-alz-pattern' into dev-alz-pattern
ymehdimsft Aug 28, 2024
dbab490
New commit
ymehdimsft Aug 28, 2024
5b9ae11
New commit
ymehdimsft Aug 28, 2024
1e87be4
New commit
ymehdimsft Aug 28, 2024
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion patterns/alz/alzArm.json
Original file line number Diff line number Diff line change
Expand Up @@ -17,7 +17,7 @@
"No"
],
"metadata": {
"displayName": "Teletry Opt Out",
"displayName": "Telemetry Opt Out",
"description": "The customer usage identifier used for telemetry purposes. The default value of False enables telemetry. The value of True disables telemetry."
}
},
Expand Down
39 changes: 39 additions & 0 deletions patterns/alz/alzArm.param.json
Original file line number Diff line number Diff line change
Expand Up @@ -1660,6 +1660,45 @@
},
"LAWDailyCapLimitAlertState": {
"value": "true"
},
"AppInsightsThrottlingLimitSeverity": {
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The new paramaters should go to the policyAssignmentParametersWeb section.

"value": "1"
},
"AppInsightsThrottlingLimitOperator": {
"value": "GreaterThan"
},
"AppInsightsThrottlingLimitTimeAggregation": {
"value": "Count"
},
"AppInsightsThrottlingLimitWindowSize": {
"value": "PT5M"
},
"AppInsightsThrottlingLimitEvaluationFrequency": {
"value": "PT5M"
},
"AppInsightsThrottlingLimitAutoMitigate": {
"value": "true"
},
"AppInsightsThrottlingLimitThreshold": {
"value": "0"
},
"AppInsightsThrottlingLimitFailingPeriods": {
"value": "1"
},
"AppInsightsThrottlingLimitEvaluationPeriods": {
"value": "1"
},
"AppInsightsThrottlingLimitPolicyEffect": {
"value": "deployIfNotExists"
},
"AppInsightsThrottlingLimitAlertState": {
"value": "true"
},
"activityAppInsightsDeletePolicyEffect": {
"value": "deployIfNotExists"
},
"activityAppInsightsDeleteAlertState": {
"value": "true"
}
}
},
Expand Down
8 changes: 6 additions & 2 deletions patterns/alz/policyDefinitions/policies-Monitoring.json

Large diffs are not rendered by default.

234 changes: 233 additions & 1 deletion patterns/alz/policyDefinitions/policySets.json
Original file line number Diff line number Diff line change
Expand Up @@ -5,7 +5,7 @@
"_generator": {
"name": "bicep",
"version": "0.29.47.4906",
"templateHash": "2221949666148884807"
"templateHash": "7726528937986136901"
}
},
"parameters": {
Expand Down Expand Up @@ -6015,6 +6015,163 @@
"displayName": "ALog Analytics Workspace Daily Cap Limit Reached Alert State",
"description": "Alert state for the alert"
}
},
"AppInsightsThrottlingLimitSeverity": {
"type": "String",
"metadata": {
"displayName": "Application Insights Throttling Limit Reached Alert Severity",
"description": "Severity of the Alert"
},
"allowedValues": [
"0",
"1",
"2",
"3",
"4"
],
"defaultValue": "2"
},
"AppInsightsThrottlingLimitOperator": {
"type": "String",
"metadata": {
"displayName": "Application Insights Throttling Limit Reached Alert Operator"
},
"allowedValues": [
"GreaterThan",
"GreaterThanOrEqual"
],
"defaultValue": "GreaterThan"
},
"AppInsightsThrottlingLimitTimeAggregation": {
"type": "String",
"metadata": {
"displayName": "Application Insights Throttling Limit Reached Alert TimeAggregation"
},
"allowedValues": [
"Count"
],
"defaultValue": "Count"
},
"AppInsightsThrottlingLimitWindowSize": {
"type": "String",
"metadata": {
"displayName": "Application Insights Throttling Limit Reached Alert Window Size",
"description": "Window size for the alert"
},
"allowedValues": [
"PT1M",
"PT5M",
"PT10M",
"PT15M",
"PT30M",
"PT45M",
"PT1H",
"PT2H",
"PT3H",
"PT4H",
"PT5H",
"PT6H",
"P1D"
],
"defaultValue": "P1D"
},
"AppInsightsThrottlingLimitEvaluationFrequency": {
"type": "String",
"metadata": {
"displayName": "Application Insights Throttling Limit Reached Alert Evaluation Frequency",
"description": "Evaluation frequency for the alert"
},
"allowedValues": [
"PT5M",
"PT10M",
"PT15M",
"PT30M",
"PT45M",
"PT1H",
"PT2H",
"PT3H",
"PT4H",
"PT5H",
"PT6H",
"P1D"
],
"defaultValue": "PT1H"
},
"AppInsightsThrottlingLimitAutoMitigate": {
"type": "String",
"metadata": {
"displayName": "Application Insights Throttling Limit Reached Alert Auto Mitigate",
"description": "Auto Mitigate for the alert"
},
"allowedValues": [
"true",
"false"
],
"defaultValue": "true"
},
"AppInsightsThrottlingLimitThreshold": {
"type": "String",
"metadata": {
"displayName": "Application Insights Throttling Limit Reached Alert Threshold",
"description": "Threshold for the alert"
},
"defaultValue": "0"
},
"AppInsightsThrottlingLimitFailingPeriods": {
"type": "String",
"metadata": {
"displayName": "Application Insights Throttling Limit Reached Alert Failing Periods",
"description": "Number of failing periods before alert is fired"
},
"defaultValue": "1"
},
"AppInsightsThrottlingLimitEvaluationPeriods": {
"type": "String",
"metadata": {
"displayName": "Application Insights Throttling Limit Reached Alert Evaluation Periods",
"description": "The number of aggregated lookback points."
},
"defaultValue": "1"
},
"AppInsightsThrottlingLimitPolicyEffect": {
"type": "string",
"defaultValue": "deployIfNotExists",
"allowedValues": [
"deployIfNotExists",
"disabled"
],
"metadata": {
"displayName": "Application Insights Throttling Limit Reached Alert Policy Effect",
"description": "Policy effect for the alert, deployIfNotExists will create the alert if it does not exist, disabled will not create the alert"
}
},
"AppInsightsThrottlingLimitAlertState": {
"type": "string",
"defaultValue": "true",
"metadata": {
"displayName": "AApplication Insights Throttling Limit Reached Alert State",
"description": "Alert state for the alert"
}
},
"activityAppInsightsDeletePolicyEffect": {
"type": "string",
"defaultValue": "deployIfNotExists",
"allowedValues": [
"deployIfNotExists",
"disabled"
],
"metadata": {
"displayName": "Activity Log Application Insights Alert Delete Policy Effect",
"description": "Policy effect for the alert, deployIfNotExists will create the alert if it does not exist, disabled will not create the alert"
}
},
"activityAppInsightsDeleteAlertState": {
"type": "string",
"defaultValue": "true",
"metadata": {
"displayName": "Activity Log Application Insights Alert Delete Alert State",
"description": "Alert state for the alert"
}
}
},
"policyDefinitions": [
Expand Down Expand Up @@ -6120,6 +6277,81 @@
}
}
},
{
"policyDefinitionReferenceId": "ALZ_AppInsightsThrottlingLimitReached_Alert",
"policyDefinitionId": "/providers/Microsoft.Management/managementGroups/contoso/providers/Microsoft.Authorization/policyDefinitions/Deploy_AppInsightsThrottlingLimit_Alert",
"parameters": {
"UAMIResourceId": {
"value": "[[[if(empty(parameters('BYOUserAssignedManagedIdentityResourceId')), concat('/subscriptions/', parameters('ALZManagementSubscriptionId'), '/resourceGroups/', parameters('ALZMonitorResourceGroupName'), '/providers/Microsoft.ManagedIdentity/userAssignedIdentities/', parameters('ALZUserAssignedManagedIdentityName')),parameters('BYOUserAssignedManagedIdentityResourceId'))]"
},
"severity": {
"value": "[[[parameters('AppInsightsThrottlingLimitSeverity')]"
},
"operator": {
"value": "[[[parameters('AppInsightsThrottlingLimitOperator')]"
},
"timeAggregation": {
"value": "[[[parameters('AppInsightsThrottlingLimitTimeAggregation')]"
},
"windowSize": {
"value": "[[[parameters('AppInsightsThrottlingLimitWindowSize')]"
},
"evaluationFrequency": {
"value": "[[[parameters('AppInsightsThrottlingLimitEvaluationFrequency')]"
},
"autoMitigate": {
"value": "[[[parameters('AppInsightsThrottlingLimitAutoMitigate')]"
},
"threshold": {
"value": "[[[parameters('AppInsightsThrottlingLimitThreshold')]"
},
"failingPeriods": {
"value": "[[[parameters('AppInsightsThrottlingLimitFailingPeriods')]"
},
"evaluationPeriods": {
"value": "[[[parameters('AppInsightsThrottlingLimitEvaluationPeriods')]"
},
"effect": {
"value": "[[[parameters('AppInsightsThrottlingLimitPolicyEffect')]"
},
"enabled": {
"value": "[[[parameters('AppInsightsThrottlingLimitAlertState')]"
},
"MonitorDisableTagName": {
"value": "[[[parameters('ALZMonitorDisableTagName')]"
},
"MonitorDisableTagValues": {
"value": "[[[parameters('ALZMonitorDisableTagValues')]"
}
}
},
{
"policyDefinitionReferenceId": "ALZ_activityAppInsightsDelete",
"policyDefinitionId": "/providers/Microsoft.Management/managementGroups/contoso/providers/Microsoft.Authorization/policyDefinitions/Deploy_ActivityLog_AppInsights_Delete",
"parameters": {
"effect": {
"value": "[[[parameters('activityAppInsightsDeletePolicyEffect')]"
},
"enabled": {
"value": "[[[parameters('activityAppInsightsDeleteAlertState')]"
},
"alertResourceGroupName": {
"value": "[[[parameters('ALZMonitorResourceGroupName')]"
},
"alertResourceGroupTags": {
"value": "[[[parameters('ALZMonitorResourceGroupTags')]"
},
"alertResourceGroupLocation": {
"value": "[[[parameters('ALZMonitorResourceGroupLocation')]"
},
"MonitorDisableTagName": {
"value": "[[[parameters('ALZMonitorDisableTagName')]"
},
"MonitorDisableTagValues": {
"value": "[[[parameters('ALZMonitorDisableTagValues')]"
}
}
},
{
"policyDefinitionReferenceId": "ALZ_AATotalJob",
"policyDefinitionId": "/providers/Microsoft.Management/managementGroups/contoso/providers/Microsoft.Authorization/policyDefinitions/Deploy_AA_TotalJob_Alert",
Expand Down
Loading