Dev alz pattern #314
Open
Dev alz pattern #314
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
troubleshooting failing remediation
adding displayname
Update Deploy-AppInsightsThrottlingLimit-Alert.json
Update Deploy-ActivityLog-AppInsights-Del.json
Fixed alert remediation
Fixed override tag name
Update Deploy-AppInsightsThrottlingLimit-Alert.json
Refining query to return only records for the selected AppInsights resource
Update Deploy-AppInsightsThrottlingLimit-Alert.json
arjenhuitema
added
Area: Policy 📝
arjenhuitema
requested changes
Aug 30, 2024
There was a problem hiding this comment.
Thanks @ymehdimsft
Let's work on making the following changes:
- These resource types typically dont exist under the
Managementmanagement group. Therefore we should include these policies not in the Management Initiative. As this regards App Insights it makes sense to add them to the Web Initiative. - The
policies.bicepwill no longer be used, and shouldn't be modified anymore and it will be removed in the near future.
| @@ -1660,6 +1660,45 @@ | |||
| }, | |||
| "LAWDailyCapLimitAlertState": { | |||
| "value": "true" | |||
| }, | |||
| "AppInsightsThrottlingLimitSeverity": { | |||
There was a problem hiding this comment.
The new paramaters should go to the policyAssignmentParametersWeb section.
| @@ -446,6 +446,163 @@ | |||
| "displayName": "ALog Analytics Workspace Daily Cap Limit Reached Alert State", | |||
| "description": "Alert state for the alert" | |||
| } | |||
| }, | |||
There was a problem hiding this comment.
Move the new policies references and paramaters to the Deploy-Web-Alerts.json
| @@ -71,6 +71,8 @@ var loadPolicyDefinitions = { | |||
| loadTextContent('../../../services/OperationalInsights/workspaces/Deploy-ActivityLog-LAWorkspace-Del.json') | |||
| loadTextContent('../../../services/OperationalInsights/workspaces/Deploy-ActivityLog-LAWorkspace-KeyRegen.json') | |||
| loadTextContent('../../../services/OperationalInsights/workspaces/Deploy-LAWorkspace-DailyCapLimitReached-Alert.json') | |||
| loadTextContent('../../../services/Insights/components/Deploy-AppInsightsThrottlingLimit-Alert.json') | |||
There was a problem hiding this comment.
Remove the new lines from here and move them to policies-Web.bicep
| @@ -167,6 +167,7 @@ var loadPolicyDefinitions = { | |||
| loadTextContent('../../../services/OperationalInsights/workspaces/Deploy-ActivityLog-LAWorkspace-Del.json') | |||
| loadTextContent('../../../services/OperationalInsights/workspaces/Deploy-ActivityLog-LAWorkspace-KeyRegen.json') | |||
| loadTextContent('../../../services/OperationalInsights/workspaces/Deploy-LAWorkspace-DailyCapLimitReached-Alert.json') | |||
| loadTextContent('../../../services/Insights/components/Deploy-AppInsightsThrottlingLimit-Alert') | |||
There was a problem hiding this comment.
Please undo this change. This file is no longer required.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Overview/Summary
Replace this with a brief description of what this Pull Request fixes, changes, etc.
This PR fixes/adds/changes/removes
Adds 2 alerts (App Insights Throttling limit reached, App Insights Delete
Breaking Changes
As part of this Pull Request I have
mainbranch