-
Notifications
You must be signed in to change notification settings - Fork 188
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: add insturmentation to attestation and epoch quote mem pools #9055
Open
Maddiaa0
wants to merge
6
commits into
master
Choose a base branch
from
md/p2p/instrument
base: master
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
+196
−47
Open
Changes from all commits
Commits
Show all changes
6 commits
Select commit
Hold shift + click to select a range
8310c3c
temp
Maddiaa0 bc2f793
feat: add metrics collecting tests to pool tests
Maddiaa0 8b43c56
fix: remove unneeded things
Maddiaa0 1719576
fmt
Maddiaa0 c1207d0
Merge branch 'master' into md/p2p/instrument
Maddiaa0 548d3cf
fmt
Maddiaa0 File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
17 changes: 16 additions & 1 deletion
17
yarn-project/p2p/src/epoch_proof_quote_pool/memory_epoch_proof_quote_pool.ts
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -1,26 +1,41 @@ | ||
import { type EpochProofQuote } from '@aztec/circuit-types'; | ||
import { type TelemetryClient } from '@aztec/telemetry-client'; | ||
|
||
import { PoolInstrumentation } from '../tx_pool/instrumentation.js'; | ||
import { type EpochProofQuotePool } from './epoch_proof_quote_pool.js'; | ||
|
||
export class MemoryEpochProofQuotePool implements EpochProofQuotePool { | ||
private quotes: Map<bigint, EpochProofQuote[]>; | ||
constructor() { | ||
private metrics: PoolInstrumentation<EpochProofQuote>; | ||
|
||
constructor(telemetry: TelemetryClient) { | ||
this.quotes = new Map(); | ||
this.metrics = new PoolInstrumentation(telemetry, 'MemoryEpochProofQuotePool'); | ||
} | ||
|
||
addQuote(quote: EpochProofQuote) { | ||
const epoch = quote.payload.epochToProve; | ||
if (!this.quotes.has(epoch)) { | ||
this.quotes.set(epoch, []); | ||
} | ||
this.quotes.get(epoch)!.push(quote); | ||
|
||
this.metrics.recordAddedObjects(1); | ||
} | ||
getQuotes(epoch: bigint): EpochProofQuote[] { | ||
return this.quotes.get(epoch) || []; | ||
} | ||
deleteQuotesToEpoch(epoch: bigint): void { | ||
const expiredEpochs = Array.from(this.quotes.keys()).filter(k => k <= epoch); | ||
|
||
let removedObjectsCount = 0; | ||
for (const expiredEpoch of expiredEpochs) { | ||
// For logging | ||
removedObjectsCount += this.quotes.get(expiredEpoch)?.length || 0; | ||
|
||
this.quotes.delete(expiredEpoch); | ||
} | ||
|
||
this.metrics.recordRemovedObjects(removedObjectsCount); | ||
} | ||
} |
Oops, something went wrong.
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This kind of stuff scares me for when things get out of sync. It doesn't feel like this should be called often- can we just call
toBuffer
and get length?There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Could cache the result if performance was a concern.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
perf was the concern, ill play with that idea though