feat: add insturmentation to attestation and epoch quote mem pools #9055
+196
−47
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
This stack of pull requests is managed by Graphite. Learn more about stacking. |
Maddiaa0
commented
Oct 7, 2024
Maddiaa0
commented
Oct 7, 2024
Maddiaa0
changed the title
just-mitch
reviewed
Oct 9, 2024
| */ | ||
| public recordAddedTxs(status: string, count = 1) { | ||
| public recordAddedObjectsWithStatus(status: string, count = 1) { |
There was a problem hiding this comment.
Bit of a nit, but I don't love needing 4 functions to add/remove with/without status. Can we just expose the raw this.objects.add function?
just-mitch
reviewed
Oct 9, 2024
| @@ -84,6 +84,11 @@ export class EpochProofQuotePayload { | |||
| }; | |||
| } | |||
|
|
|||
| getSize(): number { | |||
| // 32 bytes for epochToProve, 32 bytes for validUntilSlot, 32 bytes for bondAmount, 20 bytes for prover, 4 bytes for basisPointFee | |||
| return 32 + 32 + 32 + EthAddress.SIZE_IN_BYTES + 4; | |||
There was a problem hiding this comment.
This kind of stuff scares me for when things get out of sync. It doesn't feel like this should be called often- can we just call toBuffer and get length?
There was a problem hiding this comment.
Could cache the result if performance was a concern.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Overview
Makes the txpool instrumentation generic over the txpool object, then enables metrics on pool contents for our other mempools