Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Custom Playback Effects: Hide segmented control for local files #3097

Merged
merged 16 commits into from
Oct 28, 2024
Merged

Custom Playback Effects: Hide segmented control for local files #3097

merged 16 commits into from
Oct 28, 2024

Commits on Oct 21, 2024

  1. Add feature flag

    @ashiagr
    ashiagr committed Oct 21, 2024
    Configuration menu
    Copy the full SHA
    5192a0b View commit details
    Browse the repository at this point in the history

  2. Rename and update segmented tab bar style

    @ashiagr
    ashiagr committed Oct 21, 2024
    Configuration menu
    Copy the full SHA
    1430b70 View commit details
    Browse the repository at this point in the history

  3. Display playback effects segmented control

    @ashiagr
    ashiagr committed Oct 21, 2024
    Configuration menu
    Copy the full SHA
    ab2ba2f View commit details
    Browse the repository at this point in the history

  4. Fix accessibility

    @ashiagr
    ashiagr committed Oct 21, 2024
    Configuration menu
    Copy the full SHA
    f9337c1 View commit details
    Browse the repository at this point in the history

Commits on Oct 22, 2024

  1. Move setup to onCreateView

    @ashiagr
    ashiagr committed Oct 22, 2024
    Configuration menu
    Copy the full SHA
    433eddb View commit details
    Browse the repository at this point in the history

Commits on Oct 24, 2024

  1. Update style

    @ashiagr
    ashiagr committed Oct 24, 2024
    Configuration menu
    Copy the full SHA
    64c14cf View commit details
    Browse the repository at this point in the history

  2. Update playback effects on tab change

    @ashiagr
    ashiagr committed Oct 24, 2024
    Configuration menu
    Copy the full SHA
    92579fe View commit details
    Browse the repository at this point in the history

  3. Hide globalEffectsCard if FF enabled

    @ashiagr
    ashiagr committed Oct 24, 2024
    Configuration menu
    Copy the full SHA
    1bff2fa View commit details
    Browse the repository at this point in the history

  4. Copy local podcast playback effects to just subscribed podcast

    @ashiagr
    ashiagr committed Oct 24, 2024
    Configuration menu
    Copy the full SHA
    5bd9a66 View commit details
    Browse the repository at this point in the history

Commits on Oct 25, 2024

  1. Hide effects settings bar for local files

    @ashiagr
    ashiagr committed Oct 25, 2024
    Configuration menu
    Copy the full SHA
    25d90b4 View commit details
    Browse the repository at this point in the history

  2. Add tests

    @ashiagr
    ashiagr committed Oct 25, 2024
    Configuration menu
    Copy the full SHA
    be86870 View commit details
    Browse the repository at this point in the history

Commits on Oct 28, 2024

  1. Update distinct to compare by uuid and playback effects

    @ashiagr
    ashiagr committed Oct 28, 2024
    Configuration menu
    Copy the full SHA
    228a172 View commit details
    Browse the repository at this point in the history

  2. Merge branch 'refs/heads/main' into task/3042-local-files 

    # Conflicts:
#	modules/features/player/src/main/java/au/com/shiftyjelly/pocketcasts/player/view/EffectsFragment.kt
#	modules/features/player/src/main/java/au/com/shiftyjelly/pocketcasts/player/viewmodel/PlayerViewModel.kt
    @ashiagr
    ashiagr committed Oct 28, 2024
    Configuration menu
    Copy the full SHA
    a4ddef4 View commit details
    Browse the repository at this point in the history

  3. Fix merge

    @ashiagr
    ashiagr committed Oct 28, 2024
    Configuration menu
    Copy the full SHA
    ec63f70 View commit details
    Browse the repository at this point in the history

  4. Fix test

    @ashiagr
    ashiagr committed Oct 28, 2024
    Configuration menu
    Copy the full SHA
    dc28a0c View commit details
    Browse the repository at this point in the history

  5. Update modules/features/player/src/main/java/au/com/shiftyjelly/pocke… 

    …tcasts/player/view/EffectsFragment.kt

Co-authored-by: Michał Sikora <[email protected]>
    @ashiagr @MiSikora
    ashiagr and MiSikora authored Oct 28, 2024
    Configuration menu
    Copy the full SHA
    c9922d8 View commit details
    Browse the repository at this point in the history