Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Custom Playback Effects: Hide segmented control for local files #3097

Merged
merged 16 commits into from
Oct 28, 2024
Merged

Custom Playback Effects: Hide segmented control for local files #3097

merged 16 commits into from
Oct 28, 2024

Conversation

ashiagr
Copy link
Contributor

@ashiagr ashiagr commented Oct 25, 2024

Description

This hides effects settings segmented control for local files.

Part of #3042

Testing Instructions

  1. Play a local file
  2. Open effects view from full-screen player
  3. ✅ Notice that effects settings segmented control is not present
  4. Play a podcast file
  5. Open effects view from full-screen player
  6. ✅ Notice that effects settings segmented control is present

Screenshots or Screencast

local_files.mp4

Checklist

  • If this is a user-facing change, I have added an entry in CHANGELOG.md
  • Ensure the linter passes (./gradlew spotlessApply to automatically apply formatting/linting)
  • I have considered whether it makes sense to add tests for my changes
  • All strings that need to be localized are in modules/services/localization/src/main/res/values/strings.xml
  • Any jetpack compose components I added or changed are covered by compose previews
  • I have updated (or requested that someone edit) the spreadsheet to reflect any new or changed analytics.

I have tested any UI changes...

  • with different themes
  • with a landscape orientation
  • with the device set to have a large display and font size
  • for accessibility with TalkBack

@ashiagr ashiagr added this to the Future milestone Oct 25, 2024
@ashiagr ashiagr requested a review from a team as a code owner October 25, 2024 12:18
@ashiagr ashiagr requested review from MiSikora and removed request for a team October 25, 2024 12:18
@ashiagr ashiagr mentioned this pull request Oct 25, 2024
Closed
@dangermattic
Copy link
Collaborator

dangermattic commented Oct 25, 2024 •
edited
Loading

1 Warning
⚠️ Class PodcastEffectsData is missing tests, but unit-tests-exemption label was set to ignore this.

Generated by 🚫 Danger

@wpmobilebot
Copy link
Collaborator

wpmobilebot commented Oct 25, 2024 •
edited
Loading

📲 You can test the changes from this Pull Request in 📱 Mobile by scanning the QR code below to install the corresponding build.
App Name 📱 Mobile
Build TypedebugProd
Commitc9922d8
Direct Downloadpocketcasts-app-prototype-build-pr3097-c9922d8.apk
📲 You can test the changes from this Pull Request in 🚗 Automotive by scanning the QR code below to install the corresponding build.
App Name 🚗 Automotive
Build TypedebugProd
Commitc9922d8
Direct Downloadpocketcasts-automotive-prototype-build-pr3097-c9922d8.apk
📲 You can test the changes from this Pull Request in ⌚ Wear by scanning the QR code below to install the corresponding build.
App Name ⌚ Wear
Build TypedebugProd
Commitc9922d8
Direct Downloadpocketcasts-wear-prototype-build-pr3097-c9922d8.apk

Base automatically changed from task/3042-local-global-logic to main October 28, 2024 05:45
@ashiagr
Merge branch 'refs/heads/main' into task/3042-local-files
a4ddef4 
# Conflicts:
#	modules/features/player/src/main/java/au/com/shiftyjelly/pocketcasts/player/view/EffectsFragment.kt
#	modules/features/player/src/main/java/au/com/shiftyjelly/pocketcasts/player/viewmodel/PlayerViewModel.kt
@ashiagr
Fix merge
ec63f70
@ashiagr ashiagr enabled auto-merge (squash) October 28, 2024 05:54
@ashiagr @MiSikora
Update modules/features/player/src/main/java/au/com/shiftyjelly/pocke…
c9922d8 
…tcasts/player/view/EffectsFragment.kt

Co-authored-by: Michał Sikora <[email protected]>
@MiSikora
Copy link
Contributor

I disabled auto-merge if you want to handle my last suggestion.

@ashiagr ashiagr enabled auto-merge (squash) October 28, 2024 06:23
@ashiagr ashiagr merged commit 7d8bc72 into main Oct 28, 2024
16 checks passed
@ashiagr ashiagr deleted the task/3042-local-files branch October 28, 2024 06:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@MiSikora MiSikora MiSikora approved these changes

Assignees
No one assigned
Labels
[Project] Custom Playback Settings [Type] Feature Adding a new feature. unit-tests-exemption
Projects
None yet
Milestone
Future
Development

Successfully merging this pull request may close these issues.
4 participants
@ashiagr @dangermattic @wpmobilebot @MiSikora