Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Big fix branch for 2021 #296

Closed
wants to merge 20 commits into from
Closed

Conversation

ianfixes
Copy link
Collaborator

@ianfixes ianfixes commented Apr 4, 2021

@ianfixes ianfixes force-pushed the 2021-02-15_beta branch 2 times, most recently from 5683991 to 1676b43 Compare April 5, 2021 04:04
@hlovdal
Copy link
Contributor

hlovdal commented Apr 5, 2021

I have two fixes you can cherry-pick from the branch 2021-02-15_beta.update. The first one is trivial, but the second one about the --path argument I am not sure if is correct, so maybe just use that as a reference to investigate what the correct commands should be.

With the crlf branch merged into master, you can drop the commit "Update CHANGELOG.md to describe line endings change." from this branch.

@ianfixes
Copy link
Collaborator Author

ianfixes commented Apr 7, 2021

@hlovdal It doesn't look like there's too much to bring over ianfixes/arduino_ci@2021-02-15_beta...hlovdal:2021-02-15_beta.update

@ianfixes
Copy link
Collaborator Author

ianfixes commented Oct 4, 2021

@jgfoster I'll try to break this up into smaller pieces so we can get it merged in, but I'm not sure which of the issues fixed (see PR description) are most pressing

@jgfoster
Copy link
Member

jgfoster commented Oct 4, 2021

@ianfixes, That's fine. As you have seen, I've merged most of my changes. The one remaining is the one to build a library once and use it for the remaining tests. While this has had an enormous speed improvement in our application, I'm not seeing the same improvement in the TestSomething case. For that reason I'm holding back and on merging it till I can better document the improvement.

As to the other PRs, I do intend to review them and merge them as I understand what is happening (I've given my own preferential treatment since I understand them!).

@ianfixes
Copy link
Collaborator Author

Pulled into #334 with the exception of 1ee342c

@ianfixes
Copy link
Collaborator Author

This has merged as part of #334 and was released in v1.4.0. 1ee342c is being tracked in #337

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment