Use before(:each) rather than before(:all)

[jgfoster]

As recommended here to fix #288. This seems to fix the problem viewing the compile errors generated during a GitLab Action.

[ianfixes]

I'm not sure why this would fix the problem. Is there a confounding variable here?

If you add the foo test you showed in #288 , does the compile error actually appear in the build logs?

[jgfoster]

See https://github.com/Arduino-CI/arduino_ci/runs/2266763030 line 703.

[jgfoster]

Compare to line 703 of https://github.com/Arduino-CI/arduino_ci/runs/2266807902. I don't understand what is going on, but it just seemed odd to me to have a before(:all) and an after(:each). This wasn't balanced and I found an article that said not to use before(:all) unless you knew what you were doing (and I don't!). Since the change fixed it I was content that I was at least doing more than reporting a problem. But, I'd like someone who understands it to validate it as a reasonable solution.

[ianfixes]

Note to self,

• https://github.com/Arduino-CI/arduino_ci/runs/2266763030#step:4:707
• https://github.com/Arduino-CI/arduino_ci/runs/2266807902#step:4:707

I have your fix in #296

Thanks for the line numbers, this test gets reported in 2 places and I was originally looking at the wrong one. These build logs are enormous.