-
Notifications
You must be signed in to change notification settings - Fork 17.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Reduce memory used by DDS client #26095
Reduce memory used by DDS client #26095
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM. Hopefully upstream merges the dependencies soon with our endorsement. Once that's done, this can go in.
Nice memory reduction! |
2dfb024
to
5e82ca9
Compare
5e82ca9
to
59ca1ec
Compare
59ca1ec
to
ff6b1d8
Compare
Signed-off-by: Rhys Mainwaring <[email protected]>
Signed-off-by: Rhys Mainwaring <[email protected]>
Signed-off-by: Rhys Mainwaring <[email protected]>
ff6b1d8
to
0c47d0a
Compare
Can you squash the commits together? Each one looks good. |
Could do, though I kept them separate on purpose to make it clear what was changing: 1. removal of unused variable, 2. change in upstream dep, and 3. an unrelated bug fix. |
|
We agreed in dev call a final test on hardware would be a good idea before merging. The plan is this can be backported to 4.5 with the testing complete. I'll test on Pixhawk 6X with serial. |
Ok. I'm running on a MatekH743-WING using |
I think the testing Rhys has done is sufficient. Are we ok to merge this so it can be part of 4.5? |
Remove unused TFMessage variable and reduce size of pre-allocate arrays in XRCE DDS message types.
Dependencies
Requires upstream change:
Which are applied to the ArduPilot forks in:
Tasks
Testing
Before
After
Run on SITL and on MatekH743 / plane.