[1.0] Fix production_restart test flakiness #674
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…nal before checking pending policy
heifner
approved these changes
Aug 30, 2024
greg7mdp
approved these changes
Aug 30, 2024
| # A proposed finalizer policy is promoted to pending only after the block where it | ||
| # was proposed become irreversible. | ||
| # Wait for pending policy is in place. | ||
| assert node0.waitForTransFinalization(transId), f'setfinalizer transaction {transId} failed to be rolled into a LIB block' |
There was a problem hiding this comment.
waitForTransFinalization seems like an odd name to me? Isn't it just waitForBlockFinal?
There was a problem hiding this comment.
The function takes a transaction ID as a parameter. The name seems ok.
|
Note:start |
ericpassmore
added
the
test-instability
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The test requires pending policy to be in place. It waits on LIB. But a proposed policy is promoted to pending only after the block where it was proposed becomes final; that LIB is not necessarily the LIB where the policy was proposed.
In the test failure reported by #672, it was LIB on the block before setfinalizer because the setfinalizer was sent to the node that was not producing at the time. On the producer the setfinalizer is in the next block.
The solution is wait until the block where a finalizer policy was proposed becomes final before checking pending policy.
Resolves #672