Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Test failure: production_restart #672

Closed
heifner opened this issue Aug 30, 2024 · 1 comment · Fixed by #674 or #675
Closed

Test failure: production_restart #672

heifner opened this issue Aug 30, 2024 · 1 comment · Fixed by #674 or #675
Assignees
Labels
👍 lgtm test-instability tag issues for flaky tests, high priority to address
Milestone

Comments

@heifner
Copy link
Member

heifner commented Aug 30, 2024

https://github.com/AntelopeIO/spring/actions/runs/10621940100/job/29446218336

@heifner heifner added this to the Spring v1.0.0 milestone Aug 30, 2024
@heifner heifner added the test-instability tag issues for flaky tests, high priority to address label Aug 30, 2024
@heifner
Copy link
Member Author

heifner commented Aug 30, 2024

From Lin:

Yes,` there is a flakeness about the pending policy. We promote proposed to pending after the block which proposed the finalizer policy becomes irreversible. The test should have wait for that.

The test waits on LIB, but that LIB was not necessarily the LIB on the setfinalizer. In this test failure, it was LIB on the block before setfinalizer because the setfinalizer was sent to the node that was not producing at the time. On the producer the setfinalizer is in the next block.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
👍 lgtm test-instability tag issues for flaky tests, high priority to address
Projects
Archived in project
3 participants