[1.0] Pause production when max-reversible-blocks reached #652
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…, max-reversible-blocks does nothing.
…fects block production now.
greg7mdp
approved these changes
Aug 27, 2024
linh2931
reviewed
Aug 27, 2024
| @@ -1976,6 +1982,11 @@ producer_plugin_impl::start_block_result producer_plugin_impl::start_block() { | |||
| ("ov", _last_other_vote_received.load(std::memory_order_relaxed))("bt", _accepted_block_time)); | |||
| _pending_block_mode = pending_block_mode::speculating; | |||
| not_producing_when_time = true; | |||
| } else if (head_block_num - head.irreversible_blocknum() >= _max_reversible_blocks) { | |||
There was a problem hiding this comment.
Should >= be > as the option description says beyond?
There was a problem hiding this comment.
Need to check _max_reversible_blocks not 0. Otherwise always pause.
linh2931
requested changes
Aug 27, 2024
| @@ -1976,6 +1982,11 @@ producer_plugin_impl::start_block_result producer_plugin_impl::start_block() { | |||
| ("ov", _last_other_vote_received.load(std::memory_order_relaxed))("bt", _accepted_block_time)); | |||
| _pending_block_mode = pending_block_mode::speculating; | |||
| not_producing_when_time = true; | |||
| } else if (head_block_num - head.irreversible_blocknum() >= _max_reversible_blocks) { | |||
There was a problem hiding this comment.
Need to check _max_reversible_blocks not 0. Otherwise always pause.
linh2931
approved these changes
Aug 27, 2024
|
Note:start |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Change the behavior of
max-reversible-blocks. Instead of shutting down a node whenmax-reversible-blocksis reached; pause production.max-reversible-blocks.max-reversible-blocksis reached.A block production node will report an
error:Not producing block because max-reversible-blocks ${m} reached, head ${h}, lib ${l}.and will instead speculatively execute transactions until LIB advances. Note LIB can advance by finalizers being restored and other block producers producing blocks. Once the number of reversible blocks is reduced on the network, the block producer will un-pause and start producing blocks again.If all block producers have the same default value for
max-reversible-blocks(3600) then after approximately 30 minutes of LIB not advancing, all block producers will pause production. Manual restart of at least one block producer will be required at that point, after finality issues have been resolved, with a highermax-reversible-blocks. Once a block producer with network finalizers are able to advance finality the number of reversible blocks should be reduced back down to ~2 and all other block producers will automatically un-pause and begin producing again.Resolves #641
Resolves #634