[1.0] P2P: Prevent node from syncing too far ahead #638
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
heifner
changed the title
|
Note:start |
linh2931
reviewed
Aug 27, 2024
| @@ -2203,6 +2208,18 @@ namespace eosio { | |||
| sync_next_expected_num < sync_last_requested_num ); | |||
| } | |||
|
|
|||
| bool sync_manager::is_sync_request_ahead_allowed(block_num_type blk_num) const REQUIRES(sync_mtx) { | |||
There was a problem hiding this comment.
Not a big deal. It would be clearer in the if conditions if blk_num is renamed to next_requested_block_num.
linh2931
approved these changes
Aug 27, 2024
greg7mdp
reviewed
Aug 27, 2024
greg7mdp
approved these changes
Aug 27, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The change in #572: #572 (comment) allows a node to sync ahead when it receives a irreversible block notice. Need to verify the main thread is not trailing too far behind before requesting additional blocks.
Resolves #635