Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[4.0] Test: Fix ship test to wait on correct transaction #1388

Merged
merged 1 commit into from
Jul 11, 2023
Merged

[4.0] Test: Fix ship test to wait on correct transaction #1388

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion tests/ship_streamer_test.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -137,7 +137,7 @@ def getLatestSnapshot(nodeId):
nonProdNode.waitForTransBlockIfNeeded(trans, True, exitOnError=True)
for account in accounts:
Print(f"Transfer funds {transferAmount} from account {cluster.eosioAccount.name} to {account.name}")
nonProdNode.transferFunds(cluster.eosioAccount, account, transferAmount, "test transfer", waitForTransBlock=False)
trans=nonProdNode.transferFunds(cluster.eosioAccount, account, transferAmount, "test transfer", waitForTransBlock=False)
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This clobbers trans for each transfer, thus only waiting on the last one. I guess no material problem?

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

That is the idea. Only wait on the last one. Although, you could argue that it would be best to verify they all make it, but this is certainly faster than that.

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Although, you could argue that it would be best to verify they all make it,

yeah.. that's kind of where I was thinking. But it seems unnecessary for this test

nonProdNode.waitForTransBlockIfNeeded(trans, True, exitOnError=True)
for account in accounts:
trans=nonProdNode.delegatebw(account, 20000000.0000, 20000000.0000, waitForTransBlock=False, exitOnError=True)
Expand Down