[4.0] Test: Fix ship test to wait on correct transaction #1388
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
greg7mdp
approved these changes
Jul 11, 2023
spoonincode
approved these changes
Jul 11, 2023
| @@ -137,7 +137,7 @@ def getLatestSnapshot(nodeId): | |||
| nonProdNode.waitForTransBlockIfNeeded(trans, True, exitOnError=True) | |||
| for account in accounts: | |||
| Print(f"Transfer funds {transferAmount} from account {cluster.eosioAccount.name} to {account.name}") | |||
| nonProdNode.transferFunds(cluster.eosioAccount, account, transferAmount, "test transfer", waitForTransBlock=False) | |||
| trans=nonProdNode.transferFunds(cluster.eosioAccount, account, transferAmount, "test transfer", waitForTransBlock=False) | |||
There was a problem hiding this comment.
This clobbers trans for each transfer, thus only waiting on the last one. I guess no material problem?
There was a problem hiding this comment.
That is the idea. Only wait on the last one. Although, you could argue that it would be best to verify they all make it, but this is certainly faster than that.
There was a problem hiding this comment.
Although, you could argue that it would be best to verify they all make it,
yeah.. that's kind of where I was thinking. But it seems unnecessary for this test
linh2931
approved these changes
Jul 11, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
state_history_plugintestship_streamer_test.pywas not waiting on the correct transaction to be included in a block.Resolves #1383