-
Notifications
You must be signed in to change notification settings - Fork 70
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Invalid Base64 padding returned by APIs #1461
Milestone
Comments
There is a small chance that fixing this could "break" someone who is relying on the invalid padding. We should call this out clearly in the release notes for 5.0. |
heifner
added a commit
that referenced
this issue
Aug 8, 2023
heifner
added a commit
that referenced
this issue
Aug 8, 2023
Merged
heifner
added a commit
that referenced
this issue
Nov 13, 2023
heifner
added a commit
that referenced
this issue
Nov 13, 2023
heifner
added a commit
that referenced
this issue
Nov 13, 2023
- Use string_view and return vector<char> instead of string
heifner
added a commit
that referenced
this issue
Nov 13, 2023
heifner
added a commit
that referenced
this issue
Nov 13, 2023
[3.2] Do not require trailing `=` for base64 encoded strings
heifner
added a commit
that referenced
this issue
Nov 13, 2023
heifner
added a commit
that referenced
this issue
Nov 13, 2023
heifner
added a commit
that referenced
this issue
Nov 13, 2023
[3.2 -> 4.0] Do not require trailing `=` for base64 encoded strings
heifner
added a commit
that referenced
this issue
Nov 13, 2023
heifner
added a commit
that referenced
this issue
Nov 13, 2023
[5.0 -> main] Fix base64 encoding - take 2
heifner
added a commit
that referenced
this issue
Nov 14, 2023
[4.0 -> 5.0] Do not require trailing = for base64 encoded strings
heifner
added a commit
that referenced
this issue
Nov 14, 2023
heifner
added a commit
that referenced
this issue
Nov 14, 2023
[5.0 -> main] Benchmark BLS host functions, Do not require trailing = for base64 encoded strings
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Reference issue: EOSIO/eos#8161
Figured I'd bring this old issue up again because I just ran into this once more.
The padding used in the base64 implementation that nodeos uses to respond with in select API requests is invalid, which causes any library used to interpret that data to throw errors.
An example invalid response can be seen on Jungle4 when querying the
eosio.token
contract.Note that the end of the base64 data contained in the
.abi
field is===
, which itself is invalid padding for base64 data.We have also seen responses which include
=
when needing==
, and vice versa. Whatever code is generating the base64 representations of this data for nodeos is doing so incorrectly on multiple fronts.The text was updated successfully, but these errors were encountered: