Merge pull request #1482 from AntelopeIO/GH-1461-base64

Fix base64 encoding
AntelopeIO · Aug 10, 2023 · 4cb55b6 · 4cb55b6
2 parents 2491418 + 0842972
commit 4cb55b6
Show file tree

Hide file tree

Showing 5 changed files with 440 additions and 104 deletions.
diff --git a/libraries/libfc/include/fc/crypto/base64.hpp b/libraries/libfc/include/fc/crypto/base64.hpp
@@ -1,14 +1,15 @@
 #pragma once
 #include <string>
+#include <string_view>
 
 namespace fc {
 std::string base64_encode(unsigned char const* bytes_to_encode, unsigned int in_len);
 inline std::string base64_encode(char const* bytes_to_encode, unsigned int in_len) { return base64_encode( (unsigned char const*)bytes_to_encode, in_len); }
-std::string base64_encode( const std::string& enc );
-std::string base64_decode( const std::string& encoded_string);
+std::string base64_encode( const std::string_view& enc );
+std::string base64_decode( const std::string_view& encoded_string);
 
 std::string base64url_encode(unsigned char const* bytes_to_encode, unsigned int in_len);
 inline std::string base64url_encode(char const* bytes_to_encode, unsigned int in_len) { return base64url_encode( (unsigned char const*)bytes_to_encode, in_len); }
-std::string base64url_encode( const std::string& enc );
-std::string base64url_decode( const std::string& encoded_string);
+std::string base64url_encode( const std::string_view& enc );
+std::string base64url_decode( const std::string_view& encoded_string);
 }  // namespace fc