[3.2 -> 4.0] Do not require trailing = for base64 encoded strings
#1892
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…port non-fc valid base64 encodings
[3.2] Do not require trailing `=` for base64 encoded strings
spoonincode
approved these changes
Nov 13, 2023
greg7mdp
approved these changes
Nov 13, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
All previous versions of nodeos required a trailing
=for base64 encoded strings.fc::variantappends an extra=for all of its base64 encoded strings. However, non-fc base64 encoders do not add an extra=when one is not needed. This PR modifiesfc::variantto support non-fc base64 encoded strings that do not have the extra=.In 5.0,
fc::variantwas updated to not add the extra=to base64 encoded strings. See #1888. This PR allowsnodeosto support the new 5.0 version of base64 encoded strings.Merges
release/3.2intorelease/4.0including #1889Issue #1461