Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Adjust the pin definitions for the hardware section of the Datalogger board. #237

Merged
merged 3 commits into from
Jun 18, 2024
Merged

Adjust the pin definitions for the hardware section of the Datalogger board. #237

Show file tree
Hide file tree
Changes from 2 commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
1c62df5
Remove the non-existent LED definition.
cold63 Jun 14, 2024
f77d6f7
The definition for AMB_D4 is not connected.
cold63 Jun 14, 2024
51d2125
Update variant.h
M-ichae-l Jun 18, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 0 additions & 4 deletions Arduino_package/hardware/variants/datalogger_amb26/variant.cpp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -36,11 +36,7 @@ PinDescription g_APinDescription[TOTAL_GPIO_PIN_NUM]=
{PA_14, TYPE_DIGITAL, PIO_GPIO | PIO_GPIO_IRQ | PIO_SPI, MODE_NOT_INITIAL}, // AMB_D1
{PA_13, TYPE_DIGITAL, PIO_GPIO | PIO_GPIO_IRQ | PIO_PWM | PIO_UART | PIO_SPI, MODE_NOT_INITIAL}, // AMB_D2
{PA_12, TYPE_DIGITAL, PIO_GPIO | PIO_GPIO_IRQ | PIO_PWM | PIO_UART | PIO_SPI, MODE_NOT_INITIAL}, // AMB_D3
#ifdef BOARD_AMB26
{NC, NOT_INITIAL, NOT_INITIAL , MODE_NOT_INITIAL}, // AMB_D4
#else
{PA_30, TYPE_DIGITAL, PIO_GPIO | PIO_GPIO_IRQ | PIO_PWM , MODE_NOT_INITIAL}, // AMB_D4
#endif
{PA_28, TYPE_DIGITAL, PIO_GPIO | PIO_GPIO_IRQ | PIO_PWM , MODE_NOT_INITIAL}, // AMB_D5
{PA_26, TYPE_DIGITAL, PIO_GPIO | PIO_GPIO_IRQ | PIO_PWM | PIO_IR | PIO_I2C , MODE_NOT_INITIAL}, // AMB_D6
{PA_25, TYPE_DIGITAL, PIO_GPIO | PIO_GPIO_IRQ | PIO_PWM | PIO_IR | PIO_I2C , MODE_NOT_INITIAL}, // AMB_D7
Expand Down
3 changes: 0 additions & 3 deletions Arduino_package/hardware/variants/datalogger_amb26/variant.h
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -96,9 +96,6 @@ extern void wait_for_debug(void);
#define A6 AMB_D9 // PB_3 3.3V CH6

/* LED pin mapping */
#define LED_G AMB_D3 // Green
#define LED_R AMB_D2 // Red
#define LED_B AMB_D1 // Blue
#define LED_BUILTIN LED_G // Green
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I will put "NC" for "LED_BUILTIN", as there is no "LED_G" anymore.

Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I have changed LED_BUILTIN as NC for the LED_G no more exist.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please assign AMB_D3 to be used for LED_BUILTIN. It is used in my circuit. I did not notice the issue, sorry.

Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please assign AMB_D3 to be used for LED_BUILTIN. It is used in my circuit. I did not notice the issue, sorry.

Lets refer to the latest commit 666c2a9


/* ADC/DAC pin mapping */
Expand Down