Adjust the pin definitions for the hardware section of the Datalogger board. #237
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
M-ichae-l
reviewed
Jun 18, 2024
| @@ -96,9 +96,6 @@ extern void wait_for_debug(void); | |||
| #define A6 AMB_D9 // PB_3 3.3V CH6 | |||
|
|
|||
| /* LED pin mapping */ | |||
| #define LED_G AMB_D3 // Green | |||
| #define LED_R AMB_D2 // Red | |||
| #define LED_B AMB_D1 // Blue | |||
| #define LED_BUILTIN LED_G // Green | |||
There was a problem hiding this comment.
I will put "NC" for "LED_BUILTIN", as there is no "LED_G" anymore.
M-ichae-l
approved these changes
Jun 18, 2024
| #define LED_G AMB_D3 // Green | ||
| #define LED_R AMB_D2 // Red | ||
| #define LED_B AMB_D1 // Blue | ||
| #define LED_BUILTIN LED_G // Green |
There was a problem hiding this comment.
I have changed LED_BUILTIN as NC for the LED_G no more exist.
There was a problem hiding this comment.
Please assign AMB_D3 to be used for LED_BUILTIN. It is used in my circuit. I did not notice the issue, sorry.
There was a problem hiding this comment.
Please assign AMB_D3 to be used for LED_BUILTIN. It is used in my circuit. I did not notice the issue, sorry.
Lets refer to the latest commit 666c2a9
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
By completing this PR sufficiently, please help us to review and improve the quality of this PR and Release Notes
Description of Change
Please describe your proposed Pull Request and it's impact. \
Adjust the pin definitions
Tests and Environments
Please describe on what Hardware, SDK, IDE, OS that tested this Pull Request and how if necessary. \