improved unit tests

Alfresco · Jul 15, 2023 · ff78347 · ff78347
1 parent 37afb1d
commit ff78347
Show file tree

Hide file tree

Showing 3 changed files with 57 additions and 17 deletions.
diff --git a/lib/process-services/src/lib/process-list/services/process-filter.service.spec.ts b/lib/process-services/src/lib/process-list/services/process-filter.service.spec.ts
@@ -20,6 +20,8 @@ import { mockError, fakeProcessFiltersResponse } from '../../mock';
 import { FilterProcessRepresentationModel } from '../models/filter-process.model';
 import { ProcessFilterService } from './process-filter.service';
 import { CoreTestingModule } from '@alfresco/adf-core';
+import { setupTestBed, CoreTestingModule } from '@alfresco/adf-core';
+import { ProcessInstanceFilterRepresentation } from '@alfresco/js-api';
 
 declare let jasmine: any;
 
@@ -236,17 +238,35 @@ describe('Process filter', () => {
         });
 
         describe('isFilterAlreadyExisting', () => {
-            let dummyProcessFilters;
+            let dummyProcessFilters : FilterProcessRepresentationModel[];
+            let filterRepresentationData : ProcessInstanceFilterRepresentation;
 
             beforeEach(() => {
                 dummyProcessFilters = [
-                    { name: 'processFilter1' },
-                    { name: 'processiFlter2' }
-                ];
+                    {
+                        appId: 0,
+                        filter: filterRepresentationData,
+                        icon: 'fa-random',
+                        id: 8,
+                        index: 0,
+                        name: 'Running',
+                        recent: false,
+                        hasFilter: () => {
+                            return true;
+                        }
+                    }
+                ]
+
+                filterRepresentationData = {
+                    name : '',
+                    sort : 'created-desc',
+                    state : 'running'
+                }
+
             });
 
-            it('should return true if the filter already exists', () => {
-                const processFilterName = 'processiFlter2';
+            it('should return true if the process filter already exists', () => {
+                const processFilterName = 'Running';
                 const isFilterAlreadyExistingSpy = spyOn<any>(service, 'isFilterAlreadyExisting').and.callThrough();
 
                 const result = service.isFilterAlreadyExisting(dummyProcessFilters, processFilterName);
@@ -255,8 +275,8 @@ describe('Process filter', () => {
                 expect(result).toBe(true);
             });
 
-            it('should return false if the filter does not exist', () => {
-                const processFilterName = 'processiFlter3';
+            it('should return false if the process filter does not exist', () => {
+                const processFilterName = 'All';
                 const isFilterAlreadyExistingSpy = spyOn<any>(service, 'isFilterAlreadyExisting').and.callThrough();
 
                 const result = service.isFilterAlreadyExisting(dummyProcessFilters, processFilterName);

diff --git a/lib/process-services/src/lib/process-list/services/process-filter.service.ts b/lib/process-services/src/lib/process-list/services/process-filter.service.ts
@@ -137,7 +137,7 @@ export class ProcessFilterService {
         });
     }
 
-    isFilterAlreadyExisting(filters: any, filterName: string): boolean {
+    isFilterAlreadyExisting(filters: FilterProcessRepresentationModel[], filterName: string): boolean {
         return filters.some((existingFilter) => existingFilter.name === filterName);
     }
 

diff --git a/lib/process-services/src/lib/task-list/services/task-filter.service.spec.ts b/lib/process-services/src/lib/task-list/services/task-filter.service.spec.ts
@@ -22,6 +22,7 @@ import { FilterRepresentationModel } from '../models/filter.model';
 import { TaskFilterService } from './task-filter.service';
 import { CoreModule } from '@alfresco/adf-core';
 import { ProcessTestingModule } from '../../testing/process.testing.module';
+import { TaskFilterRepresentation } from '@alfresco/js-api';
 
 declare let jasmine: any;
 
@@ -253,17 +254,36 @@ describe('Activiti Task filter Service', () => {
    });
 
     describe('isFilterAlreadyExisting', () => {
-        let dummyTaskFilters;
+        let dummyTaskFilters : FilterRepresentationModel[];
+        let filterRepresentationData : TaskFilterRepresentation;
+        ;
+
 
         beforeEach(() => {
             dummyTaskFilters = [
-                { name: 'taskFilter1' },
-                { name: 'taskFilter2' }
-            ];
+                {
+                    appId: 0,
+                    filter: filterRepresentationData,
+                    icon: 'fa-random',
+                    id: 9,
+                    index: 0,
+                    name: 'My Tasks',
+                    recent: false,
+                    hasFilter: () => {
+                        return true;
+                    }
+                }
+            ]
+
+            filterRepresentationData = {
+                name : '',
+                sort : 'created-desc',
+                state : 'running'
+            }
         });
 
-        it('should return true if the filter already exists', () => {
-            const taskFilterName = 'taskFilter2';
+        it('should return true if the task filter already exists', () => {
+            const taskFilterName = 'My Tasks';
             const isFilterAlreadyExistingSpy = spyOn<any>(service, 'isFilterAlreadyExisting').and.callThrough();
 
             const result = service.isFilterAlreadyExisting(dummyTaskFilters, taskFilterName);
@@ -272,8 +292,8 @@ describe('Activiti Task filter Service', () => {
             expect(result).toBe(true);
         });
 
-        it('should return false if the filter does not exist', () => {
-            const taskFilterName = 'taskFilter3';
+        it('should return false if the task filter does not exist', () => {
+            const taskFilterName = 'Involved Tasks';
             const isFilterAlreadyExistingSpy = spyOn<any>(service, 'isFilterAlreadyExisting').and.callThrough();
 
             const result = service.isFilterAlreadyExisting(dummyTaskFilters, taskFilterName);