Skip to content

Commit

Permalink
renamed duplicate variables
Browse files Browse the repository at this point in the history
  • Loading branch information
SheenaMalhotra182 committed Jul 15, 2023
1 parent 96b9553 commit 37afb1d
Show file tree
Hide file tree
Showing 2 changed files with 16 additions and 16 deletions.
Original file line number Diff line number Diff line change
Expand Up @@ -236,30 +236,30 @@ describe('Process filter', () => {
});

describe('isFilterAlreadyExisting', () => {
let dummyFilter;
let dummyProcessFilters;

beforeEach(() => {
dummyFilter = [
{ name: 'filter1' },
{ name: 'filter2' }
dummyProcessFilters = [
{ name: 'processFilter1' },
{ name: 'processiFlter2' }
];
});

it('should return true if the filter already exists', () => {
const filterName = 'filter2';
const processFilterName = 'processiFlter2';
const isFilterAlreadyExistingSpy = spyOn<any>(service, 'isFilterAlreadyExisting').and.callThrough();

const result = service.isFilterAlreadyExisting(dummyFilter, filterName);
const result = service.isFilterAlreadyExisting(dummyProcessFilters, processFilterName);

expect(isFilterAlreadyExistingSpy).toHaveBeenCalled();
expect(result).toBe(true);
});

it('should return false if the filter does not exist', () => {
const filterName = 'filter3';
const processFilterName = 'processiFlter3';
const isFilterAlreadyExistingSpy = spyOn<any>(service, 'isFilterAlreadyExisting').and.callThrough();

const result = service.isFilterAlreadyExisting(dummyFilter, filterName);
const result = service.isFilterAlreadyExisting(dummyProcessFilters, processFilterName);

expect(isFilterAlreadyExistingSpy).toHaveBeenCalled();
expect(result).toBe(false);
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -253,30 +253,30 @@ describe('Activiti Task filter Service', () => {
});

describe('isFilterAlreadyExisting', () => {
let dummyFilter;
let dummyTaskFilters;

beforeEach(() => {
dummyFilter = [
{ name: 'filter1' },
{ name: 'filter2' }
dummyTaskFilters = [
{ name: 'taskFilter1' },
{ name: 'taskFilter2' }
];
});

it('should return true if the filter already exists', () => {
const filterName = 'filter2';
const taskFilterName = 'taskFilter2';
const isFilterAlreadyExistingSpy = spyOn<any>(service, 'isFilterAlreadyExisting').and.callThrough();

const result = service.isFilterAlreadyExisting(dummyFilter, filterName);
const result = service.isFilterAlreadyExisting(dummyTaskFilters, taskFilterName);

expect(isFilterAlreadyExistingSpy).toHaveBeenCalled();
expect(result).toBe(true);
});

it('should return false if the filter does not exist', () => {
const filterName = 'filter3';
const taskFilterName = 'taskFilter3';
const isFilterAlreadyExistingSpy = spyOn<any>(service, 'isFilterAlreadyExisting').and.callThrough();

const result = service.isFilterAlreadyExisting(dummyFilter, filterName);
const result = service.isFilterAlreadyExisting(dummyTaskFilters, taskFilterName);

expect(isFilterAlreadyExistingSpy).toHaveBeenCalled();
expect(result).toBe(false);
Expand Down

0 comments on commit 37afb1d

Please sign in to comment.