Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Enable profile "cloud" by default #3208

Merged
merged 4 commits into from
Nov 15, 2023

Conversation

kwin
Copy link
Contributor

@kwin kwin commented Nov 11, 2023

Document disabling cloud profile
Fix GH actions build

This closes #3201

Document disabling cloud profile
Fix GH actions build

This closes #3201
@kwin kwin marked this pull request as ready for review November 11, 2023 11:04
@kwin
Copy link
Contributor Author

kwin commented Nov 11, 2023

@royteeuwen Can you have a look at the PR?

Copy link
Contributor

@royteeuwen royteeuwen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@kwin
Copy link
Contributor Author

kwin commented Nov 11, 2023

For some weird reason the build order is wrong:

[INFO] ------------------------------------------------------------------------
[INFO] Reactor Summary for ACS AEM Commons - Reactor Project 6.3.1-SNAPSHOT:
[INFO] 
[INFO] ACS AEM Commons - Reactor Project .................. SUCCESS [  0.220 s]
[INFO] ACS AEM Commons Bundle ............................. SUCCESS [ 14.504 s]
[INFO] ACS AEM Commons Oakpal Checks ...................... SUCCESS [  1.347 s]
[INFO] ACS AEM Commons UI.Apps Package .................... SUCCESS [  4.820 s]
[INFO] ACS AEM Commons UI.Content Package ................. SUCCESS [  0.220 s]
[INFO] ACS AEM Commons Package ............................ SUCCESS [  0.775 s]
[INFO] ACS AEM Commons Bundle - Core Cloud Fragment ....... SUCCESS [  0.242 s]
[INFO] ------------------------------------------------------------------------

That is despite the fact hat ACS AEM Commons Package depends on the Core Cloud Fragment (in the profile cloud) and therefore must be built afterwards.

@kwin kwin marked this pull request as draft November 11, 2023 11:24
@kwin
Copy link
Contributor Author

kwin commented Nov 11, 2023

I created https://issues.apache.org/jira/browse/MNG-7926 for the ordering issue.

built "cloud" classifier app package only in profile "cloud"
@kwin
Copy link
Contributor Author

kwin commented Nov 12, 2023

Actually it was just a misunderstanding from my side, the activeByDefault does no activate all profiles with the same id. This activation needs to be part of each (same named) profile, as profiles are not inherited. After activating all profiles cloud by default it works as expected.

@kwin kwin marked this pull request as ready for review November 12, 2023 15:28
@kwin kwin force-pushed the bugfix/enable-cloud-profile-by-default branch from 15d5cbc to ac25ec2 Compare November 12, 2023 19:06
@davidjgonzalez
Copy link
Contributor

@kwin should this PR's build work? Or will this only work once we merge to main?

@kwin
Copy link
Contributor Author

kwin commented Nov 15, 2023

Only once we merge, GHA updates are never active from branches/forks due to security concerns.

@davidjgonzalez davidjgonzalez merged commit 519cda5 into master Nov 15, 2023
10 of 19 checks passed
@davidjgonzalez davidjgonzalez deleted the bugfix/enable-cloud-profile-by-default branch November 15, 2023 16:59
@kwin kwin mentioned this pull request Nov 15, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Github actions fail after introduction of configurations for Cloud Bundle
3 participants