Update maven.yml #3199
Update maven.yml #3199
Conversation
Codecov Report
@@ Coverage Diff @@
## master #3199 +/- ##
=========================================
Coverage 55.23% 55.23%
Complexity 5469 5469
=========================================
Files 720 720
Lines 29497 29497
Branches 3837 3837
=========================================
Hits 16293 16293
Misses 11681 11681
Partials 1523 1523 |
davidjgonzalez
added
the
Skip-Changelog
|
@davidjgonzalez Does this fix #3201 ? |
| @@ -89,7 +89,7 @@ jobs: | |||
| run: mvn -e -B -V ${{ env.MVN_GOAL }} ${{ env.MVN_ADDITIONAL_OPTS }} | |||
|
|
|||
| - name: ${{ matrix.namePrefix }} Build cloud all package with Maven ${{ env.STEP_NAME_SUFFIX }} | |||
There was a problem hiding this comment.
@royteeuwen why do we need two Maven runs at all? That is IMHO not working as the module all relies on dependencies only available in a reactor build (or if previously installed in the local repo).
There was a problem hiding this comment.
no longer required, leftover from when it was still required to run twice but after review remarks from you we were able to have one build using the cloud profile
There was a problem hiding this comment.
@davidjgonzalez could you remove this entire run (line 91 and 92) and add -P cloud to the previous run (line 89). This will release both artifacts
|
Superseded by #3208 |
No description provided.