Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove Findfmt.cmake #4069

Merged
merged 8 commits into from
Jan 5, 2024
Merged

Remove Findfmt.cmake #4069

merged 8 commits into from
Jan 5, 2024

Commits on Jan 4, 2024

  1. Remove Findfmt.cmake 

    fmt provides a cmake config files since at least version 7.0.0,
which is the minimum version supported.
Fixed some variable names, so the provided config can be used.

Signed-off-by: Dominik Wójt <[email protected]>
    @domin144
    domin144 committed Jan 4, 2024
    Configuration menu
    Copy the full SHA
    7688693 View commit details
    Browse the repository at this point in the history

  2. do copy in custom command 

    Signed-off-by: Dominik Wójt <[email protected]>
    @domin144
    domin144 committed Jan 4, 2024
    Configuration menu
    Copy the full SHA
    a1ad652 View commit details
    Browse the repository at this point in the history

  3. create internal fmt directory if missing 

    Signed-off-by: Dominik Wójt <[email protected]>
    @domin144
    domin144 committed Jan 4, 2024
    Configuration menu
    Copy the full SHA
    b75f7c1 View commit details
    Browse the repository at this point in the history

  4. fmt: add missing library type 

    Signed-off-by: Dominik Wójt <[email protected]>
    @domin144
    domin144 committed Jan 4, 2024
    Configuration menu
    Copy the full SHA
    6e011f0 View commit details
    Browse the repository at this point in the history

  5. Add missing public dependencies 

    Signed-off-by: Dominik Wójt <[email protected]>
    @domin144
    domin144 committed Jan 4, 2024
    Configuration menu
    Copy the full SHA
    4746206 View commit details
    Browse the repository at this point in the history

  6. Don't depend on fake fmt::fmt 

    Signed-off-by: Dominik Wójt <[email protected]>
    @domin144
    domin144 committed Jan 4, 2024
    Configuration menu
    Copy the full SHA
    528a0fa View commit details
    Browse the repository at this point in the history

  7. Fix dependency in INTERNALIZE_FMT case 

    Signed-off-by: Dominik Wójt <[email protected]>
    @domin144
    domin144 committed Jan 4, 2024
    Configuration menu
    Copy the full SHA
    2813308 View commit details
    Browse the repository at this point in the history

Commits on Jan 5, 2024

  1. read fmt version from fmt/core.h 

    Signed-off-by: Dominik Wójt <[email protected]>
    @domin144
    domin144 committed Jan 5, 2024
    Configuration menu
    Copy the full SHA
    8dbf427 View commit details
    Browse the repository at this point in the history