-
Notifications
You must be signed in to change notification settings - Fork 588
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Remove Findfmt.cmake #4069
Remove Findfmt.cmake #4069
Conversation
db1bf0f
to
3f29865
Compare
Conan still does not like this solution:
|
conan can be made happy with |
54014dc
to
4eeb968
Compare
Not really proud of the changes, but it should work now. |
Sorry for the delay, I've been travelling (still am, but had a little time today to catch up here). Conceptually, it's fine with me to get rid of Findfmt.cmake since our minimum fmt no longer requires it, and then cleaning up what remains. Looks like the changes as they stand are failing most of the CI tests, though.
I'll merge once that gets cleaned up. |
0a16db2
to
238d32d
Compare
Another attempt. If this does not work, I will have to get back to this next week. |
fmt provides a cmake config files since at least version 7.0.0, which is the minimum version supported. Fixed some variable names, so the provided config can be used. Signed-off-by: Dominik Wójt <[email protected]>
Signed-off-by: Dominik Wójt <[email protected]>
Signed-off-by: Dominik Wójt <[email protected]>
Signed-off-by: Dominik Wójt <[email protected]>
Signed-off-by: Dominik Wójt <[email protected]>
Signed-off-by: Dominik Wójt <[email protected]>
Signed-off-by: Dominik Wójt <[email protected]>
089a723
to
2813308
Compare
Signed-off-by: Dominik Wójt <[email protected]>
It took some tries, but it finally passes. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM, thanks for the fixes
fmt provides cmake config files since at least version 7.0.0, which is the minimum version supported. Fixed some variable names, so the provided config can be used. The previous variable names were missing, if the library was installed in a custom location, like in case of manual build or provided by conan. --------- Signed-off-by: Dominik Wójt <[email protected]>
fmt provides cmake config files since at least version 7.0.0, which is the minimum version supported. Fixed some variable names, so the provided config can be used. The previous variable names were missing, if the library was installed in a custom location, like in case of manual build or provided by conan. --------- Signed-off-by: Dominik Wójt <[email protected]> Signed-off-by: Peter Kovář <[email protected]>
Description
fmt provides cmake config files since at least version 7.0.0, which is the minimum version supported.
Fixed some variable names, so the provided config can be used.
The previous variable names were missing, if the library was installed in a custom location,
like in case of manual build or provided by conan.
Tests
Checklist:
(adding new test cases if necessary).
corresponding Python bindings (and if altering ImageBufAlgo functions, also
exposed the new functionality as oiiotool options).
already run clang-format before submitting, I definitely will look at the CI
test that runs clang-format and fix anything that it highlights as being
nonconforming.