-
Notifications
You must be signed in to change notification settings - Fork 60
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[WIP] Schema evolution registry population #430
Conversation
Easier this way to get the current version information into the whole system
Remove two step registration again
9ef43b1
to
61a4f0c
Compare
61a4f0c
to
14c2010
Compare
My earlier tests were unsuccessful due to a wrong test environment, fixing that and populating the |
50837d8
to
557f347
Compare
A new test for the renamed member variable fails, because ROOT cannot handle this on its own. This will require some work:
|
That is correct. Renaming ROOT is not able to understand / auto-derive |
superseeded by #441 |
BEGINRELEASENOTES
exactly as it appears between the two bold lines
ENDRELEASENOTES
This will be a (partial) completion of the work in #413 as this will actually start to populate the
SchemaEvolution
registry that was introduced there. Additionally, this will add (more) tests for checking whether writing data with schema version 1 can be read back using schema version 2 of the test datalayout. My current thinking is that code generation will come in another PR still, once the basic functionality has been tested end-to-end using manually implemented evolution functionality.@hegner the schema evolution tests are currently failing, because apparently ROOT is not able to do the "trivial" schema evolution of adding (and default initializing) new member variables. My thinking was that this would work out of the box, but apparently I am doing something wrong at the moment.