Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[WIP] Schema evolution registry population #430

Closed
wants to merge 13 commits into from

Conversation

tmadlener
Copy link
Collaborator

@tmadlener tmadlener commented Jun 15, 2023

BEGINRELEASENOTES

  • Thank you for writing the text to appear in the release notes. It will show up
    exactly as it appears between the two bold lines
  • ...

ENDRELEASENOTES

This will be a (partial) completion of the work in #413 as this will actually start to populate the SchemaEvolution registry that was introduced there. Additionally, this will add (more) tests for checking whether writing data with schema version 1 can be read back using schema version 2 of the test datalayout. My current thinking is that code generation will come in another PR still, once the basic functionality has been tested end-to-end using manually implemented evolution functionality.

@hegner the schema evolution tests are currently failing, because apparently ROOT is not able to do the "trivial" schema evolution of adding (and default initializing) new member variables. My thinking was that this would work out of the box, but apparently I am doing something wrong at the moment.

@tmadlener
Copy link
Collaborator Author

My earlier tests were unsuccessful due to a wrong test environment, fixing that and populating the SchemaEvolution registry with the trivial evolution function makes some of the evolutions work with ROOT.

@tmadlener
Copy link
Collaborator Author

A new test for the renamed member variable fails, because ROOT cannot handle this on its own. This will require some work:

  • The CollectionBufferFactory has to be made aware of the Backend
  • There needs to be logic in the population of the factory, but also during calling to handle the Backend as additional condition
  • evolution function (manual to start with)

@hegner
Copy link
Collaborator

hegner commented Jun 27, 2023

A new test for the renamed member variable fails, because ROOT cannot handle this on its own.

That is correct. Renaming ROOT is not able to understand / auto-derive

@tmadlener
Copy link
Collaborator Author

superseeded by #441

@tmadlener tmadlener closed this Jul 11, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants