Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[WIP] Schema evolution code generation #441

Closed
wants to merge 37 commits into from
Closed

Conversation

hegner
Copy link
Collaborator

@hegner hegner commented Jul 10, 2023

BEGINRELEASENOTES

  • Thank you for writing the text to appear in the release notes. It will show up
    exactly as it appears between the two bold lines
  • ...

ENDRELEASENOTES

Based on #430

@tmadlener
Copy link
Collaborator

tmadlener commented Jul 11, 2023

Based on #430

Just for clarification from my side: This means we still keep 430 as it is and merge it separately, or we close that and keep this one for the feature?

@hegner
Copy link
Collaborator Author

hegner commented Jul 11, 2023

Since I am fixing bugs in #430, I think we better close it. I previously thought functionality in there was stable.

@tmadlener
Copy link
Collaborator

Rebased this onto #460. For me locally there are a few test issues with the datamodel storage roundtrip tests, because they now trip over the fact that for the schema evolution tests we generate "old" Data.h headers into the same directory. This makes the final diff step in those tests fail.

I don't have a real fix for that yet, but I would simply wait for now to see how the final solution to schema evolution looks like and then fix those tests afterwards.

@hegner
Copy link
Collaborator Author

hegner commented Sep 12, 2023

Since based on #430 , this development will not be integrated.

@hegner hegner closed this Sep 12, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants