Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update pre-industrial configuration with latest payu updates #42

Merged
merged 10 commits into from
Aug 9, 2024

Conversation

blimlim
Copy link

@blimlim blimlim commented Aug 7, 2024

This pull request completes the pre-industrial half of #40. It modifies the configuration with the following changes:

  • Remove um_env.py file now that it has been replaced by the um_env.yaml file.
  • Remove unused atmosphere configuration files Remove unused configuration files from atmosphere directory #27.
  • Add/update the following settings in the config.yaml file:
    • Add commented out shortpath and project settings
    • Add sync settings with default false setting. Add comment explaining compatibility with postscripts
    • Add restart_freq setting with default value of 5.
    • Add runlog and platform settings with default values.
    • Add manifest: reproduce: exe: True as in the OM2 configurations.

It would be great to get a check over these changes, especially to confirm that the default values for several of the new config.yaml settings are suitable for ESM1.5.

@blimlim
Copy link
Author

blimlim commented Aug 7, 2024

I'll wait until #38 is merged and update this branch with the changes before trying to merge.

Copy link
Member

@aidanheerdegen aidanheerdegen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Some changes, some comments and some questions.

config.yaml Outdated Show resolved Hide resolved
config.yaml Outdated Show resolved Hide resolved
config.yaml Outdated Show resolved Hide resolved
config.yaml Outdated Show resolved Hide resolved
config.yaml Show resolved Hide resolved
config.yaml Show resolved Hide resolved
blimlim and others added 4 commits August 8, 2024 14:59
use updated module path for model executable

Co-authored-by: Aidan Heerdegen <[email protected]>
Remove platform settings

Co-authored-by: Aidan Heerdegen <[email protected]>
Copy link
Member

@aidanheerdegen aidanheerdegen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Sorry! One more change required it seems.

config.yaml Show resolved Hide resolved
Copy link
Member

@aidanheerdegen aidanheerdegen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

All good to merge, thanks @blimlim!

@blimlim
Copy link
Author

blimlim commented Aug 9, 2024

Thanks for the review! There will be a similar one soon with the same changes for the historical configuration. I've added in all the changes from the discussion here and so hopefully that one won't be too involved!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants