Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update historical configuration with latest payu changes #43

Merged

Conversation

blimlim
Copy link

@blimlim blimlim commented Aug 9, 2024

This pull request completes the historical half of #40. It modifies the configuration with the following changes:

  • Use new module settings for model executables
  • Remove um_env.py file now that it has been replaced by the um_env.yaml file.
  • Remove unused atmosphere configuration files Remove unused configuration files from atmosphere directory #27.
  • Add/update the following settings in the config.yaml file:
    • Add commented out shortpath and project settings
    • Add sync settings with default false setting. Add comment explaining compatibility with postscripts
    • Add restart_freq setting with default value of 10YS.
    • Add runlog settings with default values.
    • Add manifest: reproduce: exe: True as in the OM2 configurations.
    • Increase walltime to 2:30 to guard against occasional slow simulations.

The settings have been chosen to match those used in the updated pre-industrial configuration via #42.

Also changed the target of this PR to the dev-historical+concentrations branch, which required the addition of files to make the QA checks pass.

Copy link
Member

@aidanheerdegen aidanheerdegen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

There seems to be some mismatch between the inputs for config.yaml and um_env.yaml

atmosphere/um_env.yaml Outdated Show resolved Hide resolved
atmosphere/um_env.yaml Show resolved Hide resolved
atmosphere/um_env.yaml Show resolved Hide resolved
atmosphere/um_env.yaml Show resolved Hide resolved
atmosphere/um_env.yaml Show resolved Hide resolved
@blimlim blimlim changed the base branch from historical to dev-historical+concentrations August 12, 2024 04:21
@blimlim blimlim force-pushed the 40-update-historical-payu-changes branch from e683fb7 to a2f0a18 Compare August 12, 2024 04:26
aidanheerdegen
aidanheerdegen previously approved these changes Aug 13, 2024
Copy link
Member

@aidanheerdegen aidanheerdegen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

config.yaml Outdated Show resolved Hide resolved
Copy link
Member

@aidanheerdegen aidanheerdegen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@CodeGat CodeGat merged commit 63f4033 into dev-historical+concentrations Aug 13, 2024
11 checks passed
@blimlim blimlim deleted the 40-update-historical-payu-changes branch August 23, 2024 00:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants