Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Support existingSecret for redis configuration #81

Open
wants to merge 5 commits into
base: main
Choose a base branch
from
Open

Support existingSecret for redis configuration #81

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
5 commits
Select commit Hold shift + click to select a range
11fbdc4
feat: support existing secret for Redis password
Mar 1, 2024
380820e
Merge branch '8gears:master' into master
sebastiansterk Mar 1, 2024
8f0e101
chore: rename redis password secret key
sebastiansterk Apr 2, 2024
272c4a5
chore: rename existingSecretKey to existingSecretPasswordKey
sebastiansterk Apr 2, 2024
b472415
chore: rename existingSecretKey to existingSecretPasswordKey
sebastiansterk Apr 2, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 2 additions & 0 deletions README.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -280,6 +280,8 @@ scaling:
redis:
host:
password:
existingSecret:
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can you uncomment those two lines, as they are optional.
Also you can add a comment above explaining the purpose of those two entries.

existingSecretPasswordKey:

redis:
enabled: false
Expand Down
7 changes: 7 additions & 0 deletions templates/_helpers.tpl
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -92,6 +92,13 @@ Selector labels
- name: "QUEUE_BULL_REDIS_PASSWORD"
value: "{{ .Values.scaling.redis.password }}"
{{ end }}
{{- if and .Values.scaling.redis.existingSecret .Values.scaling.redis.existingSecretPasswordKey }}
- name: "QUEUE_BULL_REDIS_PASSWORD"
valueFrom:
secretKeyRef:
name: {{ .Values.scaling.redis.existingSecret }}
key: {{ .Values.scaling.redis.existingSecretPasswordKey }}
{{ end }}
{{- if .Values.scaling.webhook.enabled }}
- name: "N8N_DISABLE_PRODUCTION_MAIN_PROCESS"
value: "true"
Expand Down
2 changes: 2 additions & 0 deletions values.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -321,6 +321,8 @@ scaling:
redis:
host:
password:
existingSecret:
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can you uncomment those two lines, as they are optional.
Also you can add a comment above explaining the purpose of those two entries.

existingSecretPasswordKey:


## Bitnami Redis configuration
Expand Down