Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support existingSecret for redis configuration #81

Open
wants to merge 5 commits into
base: main
Choose a base branch
from

Conversation

sebastiansterk
Copy link
Contributor

@sebastiansterk sebastiansterk commented Mar 1, 2024

Introduces scaling.redis.existingSecret and scaling.redis.existingSecretKey to enable referencing an existing secret containing the Redis password. This aligns with the Bitnami Redis chart, allowing both to use the same secret.

@sebastiansterk sebastiansterk requested a review from a team as a code owner March 1, 2024 07:33
README.md Outdated Show resolved Hide resolved
Copy link
Member

@Vad1mo Vad1mo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Will merge, after resolving the discussion.

@@ -321,6 +321,8 @@ scaling:
redis:
host:
password:
existingSecret:
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can you uncomment those two lines, as they are optional.
Also you can add a comment above explaining the purpose of those two entries.

@@ -280,6 +280,8 @@ scaling:
redis:
host:
password:
existingSecret:
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can you uncomment those two lines, as they are optional.
Also you can add a comment above explaining the purpose of those two entries.

@gitmonster
Copy link

Is there any progress with this merger? This feature is highly appreciated.

@Vad1mo
Copy link
Member

Vad1mo commented Jul 18, 2024

Will merge, after resolving the discussion.

yes, see #81 (review)

@gitmonster
Copy link

Will merge, after resolving the discussion.

yes, see #81 (review)

So @sebastiansterk are you able to set the commenting?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants