8 improve save functionality for isp modules #9
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* Added Sharpen Module * Updated block diagram, readme, user guide * parameters tuning for Shar[en Filter * Updated Results and Algo Description Document * Minor error fixing in Readme * RTL recommended changes made in AE and AWB * Removed Linting Errors
- added function raw_to_rgb to ceate 3channel rgb image to save module level output for modules that work with raw image. - added yuv_to_rgb function from RGBC to utils. This function is used to convert yuv image to rgb image to save module output for for modules that work with yuv image.
replaced raw_to_rgb function with apply_cfa in utils.py
sohaibimran-10xe
pushed a commit
that referenced
this pull request
Aug 21, 2024
Added features: Automation Script configs.yaml file format preservation and Results folder preservation * automate_execution currently works on config_automate file to generate RTL compatible results. * added in_single_folder flag to set the structure of the out_for_RTL folder. If True, all input files are saved in a single folder. * - automate_execution.py works on configs.yml now instead of a separate config_automate.yml. - added is_save flag in configs.yml * - verified results by matching .npy files, they match. - exception added if ValueError is encountered while loading np arrays. * - foldername(line 63) now specified by datetime obj - added compare_output file (Inprogress) - made chnages to handle new foldername in rename_to_RTL in utils.py * output of the default modules can now by saved using is_save flag in automate_execution script. * To test multiple modules, type of DUT changed from str to list. * added input_ext variable to specify raw file extension. * created Results folder in out_for_RTL. This folder will save the input and output arrays to ISP piepline, whether generted while executing isp_pipeline.py individually or using the auatomation script. * Added functions in utils.py to dump config file in a more readable format. * added .gitkeep file in results * added .gitkeep file in out_for _RTL --------- Co-authored-by: taimur-10xe <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Currently save method works fine for modules that output an RGB image but the current output for modules in Bayer raw and YUV do not visually depict the actual result. The saved Bayer raw appear bluish and the YUV images appear pink due to the default cmap (viridis) used to save the image with matplotlib.
To improve the appearance of the saved results, the Bayer raw image is converted to RGB image by inserting zeros in place of unknown values in the respective channels and YUV image is also converted to RGB before saving.
The results are shown in the issues tab.