Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Improve save functionality for ISP modules #8

Open
bakhtawar-10xe opened this issue Sep 21, 2023 · 1 comment · May be fixed by #9
Open

Improve save functionality for ISP modules #8

bakhtawar-10xe opened this issue Sep 21, 2023 · 1 comment · May be fixed by #9
Assignees
@marianadeem-10xe
Labels
enhancement New feature or request

Comments

@bakhtawar-10xe
Copy link
Contributor

Currently save method works fine for modules that output an RGB image but the current output for modules in bayer raw and YUV do not visually depict the actual result

Module Output:
BLC (Bayer Raw)
Out_black_level_correction_ColorChecker_2592x1536_10bit_GRBG

Demosaic (RGB)
Out_demosaic_ColorChecker_2592x1536_10bit_GRBG

2DNR (YUV)
Out_2d_noise_reduction_ColorChecker_2592x1536_10bit_GRBG
@sohaibimran-10xe sohaibimran-10xe added the enhancement New feature or request label Sep 21, 2023
@marianadeem-10xe
Copy link
Contributor

Updated the save method by the addition of the following two functions:

  • added function raw_to_rgb in utils.py
    To save .png file for modules returning a bayer raw image, the raw image is first converted to RGB image by defining the 3 channels as shown below:
    image
  • added yuv_to_rgb function from RGBC to utils.py.
    To save .png file for modules returning a YUV image, yuv_to_rgb function is used to convert yuv image to rgb
    image before saving.

Module Output:
BLC (Bayer Raw)
Out_black_level_correction_ColorChecker_2592x1536_10bit_GRBG

Demosaic (RGB)
Out_demosaic_ColorChecker_2592x1536_10bit_GRBG

2DNR (YUV)
Out_2d_noise_reduction_ColorChecker_2592x1536_10bit_GRBG

@marianadeem-10xe marianadeem-10xe linked a pull request Sep 25, 2023 that will close this issue
8 improve save functionality for isp modules #9
Open
sohaibimran-10xe pushed a commit that referenced this issue Aug 21, 2024
@taimur-10xe @muqudas-10xe @marianadeem-10xe
Testvec gen2: BLC WB update PR (#8)
a49fa10 
* Copy of infiniteISP v1.1

* Update CCM for RTL, change CCM matrix from config

* Update CSC for RTL, change np.round

* remove float32

* disable sharpen, enable linearization

* change CSC 8 bit division

* rounding off after 2**4 division

* automate_execution currently works on config_automate file to
generate RTL compatible results.

* added in_single_folder flag to set the structure
of the out_for_RTL folder.
If True, all input files are saved in a single folder.

* - automate_execution.py works on configs.yml now
instead of a separate config_automate.yml.
- added is_save flag in configs.yml

* added DG manual flag to bypass auto update by AE operation

* added images to complete 8 sensor RAW inputs

* added short script to output 16-bit reg value for WB gains in config file

* shifted fixed float fraction list to relevant function description

* changes made to run script for windows OS

* added blc scaling factor register value conversion

* generated test vectors in .raw for RAW domain ISP blocks

* modified oecf to default value

* changed altered OECF to default LUT state

* modified printing of linearization factor

* added printing of fixed point WB gains

* BLC and WB tv generation

* function arguments updated

---------

Co-authored-by: muqudas-10xe <[email protected]>
Co-authored-by: Maria_Nadeem-10x <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@marianadeem-10xe marianadeem-10xe

Labels
enhancement New feature or request
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

8 improve save functionality for isp modules 10x-Engineers/Infinite-ISP_ReferenceModel
3 participants
@sohaibimran-10xe @bakhtawar-10xe @marianadeem-10xe