Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: post.link #712
feat: post.link #712
Changes from 11 commits
29c711f
cb98f07
4443860
d275bfd
76cda9f
687357b
62ad64c
afd2075
c3f753c
9e05f44
de5c030
ac7fd33
933a2b6
af7cddd
d7328d2
85f4f2e
d153b09
File filter
Filter by extension
Conversations
Jump to
There are no files selected for viewing
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
will this have any impact if usePostLinkForRedirect is false? should this logic be optional?
Just thinking In a client-project we filter post_type_link to have a structure with taxonomy in it, we had to add a check on the empty post name to not filter the link on drafts as preview would break.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
it would be a interesting use case to test. This code uses
get_sample_permalink
which still callsget_permalink
so it would catch the changes you would have made for cpts.There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I've reworked things a bit. I'm returning the draft permalink via a new rest field that only gets used when the settting is enabled on the framework.
Therefore it won't cause any breakages in existing code. I've also added a test for a usecase like you mentioned and as you can see it works fine as long as you default post name to something.
I'll also update docs with best pratices for making this change work with custom permalinks like you mentioned