feat: post.link #712

nicholasio · 2024-03-01T13:26:49Z

Description of the Change

Closes #700

How to test the Change

npm run dev
Open WordPress and try previewing both post/pages in draft status and published/revisions posts.

Checklist:

I agree to follow this project's Code of Conduct.
I have updated the documentation accordingly.
I have added tests to cover my change.
All new and existing tests pass.

changeset-bot · 2024-03-01T13:26:53Z

🦋 Changeset detected

Latest commit: d153b09

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 3 packages

Name	Type
@headstartwp/headstartwp	Patch
@headstartwp/core	Patch
@headstartwp/next	Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

vercel · 2024-03-01T13:26:55Z

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name	Status	Preview	Comments	Updated (UTC)
headstarwp	✅ Ready (Inspect)	Visit Preview	💬 Add feedback	Mar 11, 2024 1:59pm

github-actions · 2024-03-01T13:29:49Z

📦 Next.js Bundle Analysis for @10up/headless_framework

This analysis was generated by the Next.js Bundle Analysis action. 🤖

This PR introduced no changes to the JavaScript bundle! 🙌

github-actions · 2024-03-02T17:22:54Z

📦 Next.js Bundle Analysis for @10up/headless_framework

This analysis was generated by the Next.js Bundle Analysis action. 🤖

This PR introduced no changes to the JavaScript bundle! 🙌

…en previewing

github-actions · 2024-03-04T14:40:16Z

📦 Next.js Bundle Analysis for @10up/headless_framework

This analysis was generated by the Next.js Bundle Analysis action. 🤖

This PR introduced no changes to the JavaScript bundle! 🙌

github-actions · 2024-03-04T14:42:41Z

📦 Next.js Bundle Analysis for @10up/headless_framework

This analysis was generated by the Next.js Bundle Analysis action. 🤖

This PR introduced no changes to the JavaScript bundle! 🙌

github-actions · 2024-03-04T14:45:35Z

📦 Next.js Bundle Analysis for @10up/headless_framework

This analysis was generated by the Next.js Bundle Analysis action. 🤖

This PR introduced no changes to the JavaScript bundle! 🙌

github-actions · 2024-03-04T18:27:02Z

📦 Next.js Bundle Analysis for @10up/headless_framework

This analysis was generated by the Next.js Bundle Analysis action. 🤖

This PR introduced no changes to the JavaScript bundle! 🙌

github-actions · 2024-03-04T18:28:46Z

📦 Next.js Bundle Analysis for @10up/headless_framework

This analysis was generated by the Next.js Bundle Analysis action. 🤖

⚠️ Global Bundle Size Increased

Page	Size (compressed)
`global`	`123.18 KB` (🟡 +20 B)

Details

The global bundle is the javascript bundle that loads alongside every page. It is in its own category because its impact is much higher - an increase to its size means that every page on your website loads slower, and a decrease means every page loads faster.

Any third party scripts you have added directly to your app using the <script> tag are not accounted for in this analysis

If you want further insight into what is behind the changes, give @next/bundle-analyzer a try!

github-actions · 2024-03-04T18:53:41Z

📦 Next.js Bundle Analysis for @10up/headless_framework

This analysis was generated by the Next.js Bundle Analysis action. 🤖

⚠️ Global Bundle Size Increased

Page	Size (compressed)
`global`	`123.18 KB` (🟡 +20 B)

Details

The global bundle is the javascript bundle that loads alongside every page. It is in its own category because its impact is much higher - an increase to its size means that every page on your website loads slower, and a decrease means every page loads faster.

Any third party scripts you have added directly to your app using the <script> tag are not accounted for in this analysis

If you want further insight into what is behind the changes, give @next/bundle-analyzer a try!

github-actions · 2024-03-06T20:06:39Z

📦 Next.js Bundle Analysis for @10up/headless_framework

This analysis was generated by the Next.js Bundle Analysis action. 🤖

⚠️ Global Bundle Size Increased

Page	Size (compressed)
`global`	`123.19 KB` (🟡 +23 B)

Details

The global bundle is the javascript bundle that loads alongside every page. It is in its own category because its impact is much higher - an increase to its size means that every page on your website loads slower, and a decrease means every page loads faster.

Any third party scripts you have added directly to your app using the <script> tag are not accounted for in this analysis

If you want further insight into what is behind the changes, give @next/bundle-analyzer a try!

packages/next/src/handlers/__tests__/previewHandler.ts

lucymtc · 2024-03-09T12:09:53Z

wp/headless-wp/includes/classes/Preview/PreviewLink.php

+
+		add_filter( 'post_link', [ $this, 'force_posts_drafts_to_have_permalinks' ], 10, 2 );
+		add_filter( 'post_type_link', [ $this, 'force_cpts_drafts_to_have_permalinks' ], 10, 2 );
+		add_action( 'page_link', [ $this, 'force_page_drafts_to_have_permalinks' ], 10, 2 );


will this have any impact if usePostLinkForRedirect is false? should this logic be optional?

Just thinking In a client-project we filter post_type_link to have a structure with taxonomy in it, we had to add a check on the empty post name to not filter the link on drafts as preview would break.

it would be a interesting use case to test. This code uses get_sample_permalink which still calls get_permalink so it would catch the changes you would have made for cpts.

I've reworked things a bit. I'm returning the draft permalink via a new rest field that only gets used when the settting is enabled on the framework.

Therefore it won't cause any breakages in existing code. I've also added a test for a usecase like you mentioned and as you can see it works fine as long as you default post name to something.

I'll also update docs with best pratices for making this change work with custom permalinks like you mentioned

github-actions · 2024-03-09T14:16:34Z

📦 Next.js Bundle Analysis for @10up/headless_framework

This analysis was generated by the Next.js Bundle Analysis action. 🤖

⚠️ Global Bundle Size Increased

Page	Size (compressed)
`global`	`123.19 KB` (🟡 +23 B)

Details

The global bundle is the javascript bundle that loads alongside every page. It is in its own category because its impact is much higher - an increase to its size means that every page on your website loads slower, and a decrease means every page loads faster.

Any third party scripts you have added directly to your app using the <script> tag are not accounted for in this analysis

If you want further insight into what is behind the changes, give @next/bundle-analyzer a try!

github-actions · 2024-03-09T14:18:52Z

📦 Next.js Bundle Analysis for @10up/headless_framework

This analysis was generated by the Next.js Bundle Analysis action. 🤖

⚠️ Global Bundle Size Increased

Page	Size (compressed)
`global`	`123.19 KB` (🟡 +23 B)

Details

The global bundle is the javascript bundle that loads alongside every page. It is in its own category because its impact is much higher - an increase to its size means that every page on your website loads slower, and a decrease means every page loads faster.

Any third party scripts you have added directly to your app using the <script> tag are not accounted for in this analysis

If you want further insight into what is behind the changes, give @next/bundle-analyzer a try!

github-actions · 2024-03-09T14:21:02Z

📦 Next.js Bundle Analysis for @10up/headless_framework

This analysis was generated by the Next.js Bundle Analysis action. 🤖

⚠️ Global Bundle Size Increased

Page	Size (compressed)
`global`	`123.19 KB` (🟡 +23 B)

Details

The global bundle is the javascript bundle that loads alongside every page. It is in its own category because its impact is much higher - an increase to its size means that every page on your website loads slower, and a decrease means every page loads faster.

Any third party scripts you have added directly to your app using the <script> tag are not accounted for in this analysis

If you want further insight into what is behind the changes, give @next/bundle-analyzer a try!

github-actions · 2024-03-09T17:30:08Z

📦 Next.js Bundle Analysis for @10up/headless_framework

This analysis was generated by the Next.js Bundle Analysis action. 🤖

⚠️ Global Bundle Size Increased

Page	Size (compressed)
`global`	`123.19 KB` (🟡 +23 B)

Details

The global bundle is the javascript bundle that loads alongside every page. It is in its own category because its impact is much higher - an increase to its size means that every page on your website loads slower, and a decrease means every page loads faster.

Any third party scripts you have added directly to your app using the <script> tag are not accounted for in this analysis

If you want further insight into what is behind the changes, give @next/bundle-analyzer a try!

github-actions · 2024-03-10T00:52:22Z

📦 Next.js Bundle Analysis for @10up/headless_framework

This analysis was generated by the Next.js Bundle Analysis action. 🤖

⚠️ Global Bundle Size Increased

Page	Size (compressed)
`global`	`123.19 KB` (🟡 +23 B)

Details

The global bundle is the javascript bundle that loads alongside every page. It is in its own category because its impact is much higher - an increase to its size means that every page on your website loads slower, and a decrease means every page loads faster.

Any third party scripts you have added directly to your app using the <script> tag are not accounted for in this analysis

If you want further insight into what is behind the changes, give @next/bundle-analyzer a try!

lucymtc

approving.
@nicholasio just a comment on the naming, I se some hooks in the plugin are prefixed with tenup_headless_wp_ others are prefixed with headless_wp wondering if the naming for preview link should be _tenup_preview_link or _headless_wp_preview_link

github-actions · 2024-03-11T14:01:31Z

📦 Next.js Bundle Analysis for @10up/headless_framework

This analysis was generated by the Next.js Bundle Analysis action. 🤖

⚠️ Global Bundle Size Increased

Page	Size (compressed)
`global`	`123.19 KB` (🟡 +23 B)

Details

The global bundle is the javascript bundle that loads alongside every page. It is in its own category because its impact is much higher - an increase to its size means that every page on your website loads slower, and a decrease means every page loads faster.

Any third party scripts you have added directly to your app using the <script> tag are not accounted for in this analysis

If you want further insight into what is behind the changes, give @next/bundle-analyzer a try!

feat: post.link

29c711f

vercel bot deployed to Preview – headstarwp March 1, 2024 13:27 View deployment

feat: forcing drafts to have permalinks

cb98f07

vercel bot deployed to Preview – headstarwp March 2, 2024 17:20 View deployment

nicholasio added 2 commits March 4, 2024 10:30

Merge branch 'develop' into feature/preview-redirect-post-link

4443860

feat: add ability to use post.link to redirect to the proper route wh…

d275bfd

…en previewing

vercel bot deployed to Preview – headstarwp March 4, 2024 14:38 View deployment

refactor: remove unnecessary code

76cda9f

vercel bot deployed to Preview – headstarwp March 4, 2024 14:40 View deployment

fix: address phpcs

687357b

vercel bot deployed to Preview – headstarwp March 4, 2024 14:43 View deployment

test: add phpunit tests

62ad64c

vercel bot deployed to Preview – headstarwp March 4, 2024 17:39 View deployment

test: add previewHandler test

afd2075

vercel bot deployed to Preview – headstarwp March 4, 2024 18:15 View deployment

nicholasio added 2 commits March 4, 2024 15:48

docs: add docs

c3f753c

chore: changeset

9e05f44

vercel bot deployed to Preview – headstarwp March 4, 2024 18:51 View deployment

nicholasio marked this pull request as ready for review March 4, 2024 18:51

nicholasio requested review from lucymtc and johnwatkins0 March 4, 2024 18:51

nicholasio requested a review from joshuaabenazer March 4, 2024 18:52

Merge branch 'develop' into feature/preview-redirect-post-link

de5c030

vercel bot deployed to Preview – headstarwp March 6, 2024 20:04 View deployment

lucymtc reviewed Mar 9, 2024

View reviewed changes

refactor: change approach

ac7fd33

vercel bot deployed to Preview – headstarwp March 9, 2024 14:14 View deployment

chore: fix typo

933a2b6

vercel bot deployed to Preview – headstarwp March 9, 2024 14:16 View deployment

chore: remove unnecessary code

af7cddd

vercel bot deployed to Preview – headstarwp March 9, 2024 14:18 View deployment

docs: update docs

d7328d2

vercel bot deployed to Preview – headstarwp March 9, 2024 17:27 View deployment

refactor: only add _tenup_preview_link for preview requests

85f4f2e

vercel bot deployed to Preview – headstarwp March 10, 2024 00:50 View deployment

lucymtc approved these changes Mar 11, 2024

View reviewed changes

refactor: rename _tenup_preview_link to _headless_wp_preview_link

d153b09

vercel bot deployed to Preview – headstarwp March 11, 2024 13:59 View deployment

nicholasio merged commit 26246a0 into develop Mar 11, 2024
13 checks passed

nicholasio deleted the feature/preview-redirect-post-link branch March 11, 2024 14:03

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

feat: post.link #712

feat: post.link #712

nicholasio commented Mar 1, 2024 •

edited

Loading

changeset-bot bot commented Mar 1, 2024 •

edited

Loading

vercel bot commented Mar 1, 2024 •

edited

Loading

github-actions bot commented Mar 1, 2024

github-actions bot commented Mar 2, 2024

github-actions bot commented Mar 4, 2024

github-actions bot commented Mar 4, 2024

github-actions bot commented Mar 4, 2024

github-actions bot commented Mar 4, 2024

github-actions bot commented Mar 4, 2024

github-actions bot commented Mar 4, 2024

github-actions bot commented Mar 6, 2024

lucymtc Mar 9, 2024 •

edited by nicholasio

Loading

nicholasio Mar 9, 2024

nicholasio Mar 9, 2024

github-actions bot commented Mar 9, 2024

github-actions bot commented Mar 9, 2024

github-actions bot commented Mar 9, 2024

github-actions bot commented Mar 9, 2024

github-actions bot commented Mar 10, 2024

lucymtc left a comment

github-actions bot commented Mar 11, 2024

feat: post.link #712

feat: post.link #712

Conversation

nicholasio commented Mar 1, 2024 • edited Loading

Description of the Change

How to test the Change

Checklist:

changeset-bot bot commented Mar 1, 2024 • edited Loading

🦋 Changeset detected

vercel bot commented Mar 1, 2024 • edited Loading

github-actions bot commented Mar 1, 2024

📦 Next.js Bundle Analysis for @10up/headless_framework

github-actions bot commented Mar 2, 2024

📦 Next.js Bundle Analysis for @10up/headless_framework

github-actions bot commented Mar 4, 2024

📦 Next.js Bundle Analysis for @10up/headless_framework

github-actions bot commented Mar 4, 2024

📦 Next.js Bundle Analysis for @10up/headless_framework

github-actions bot commented Mar 4, 2024

📦 Next.js Bundle Analysis for @10up/headless_framework

github-actions bot commented Mar 4, 2024

📦 Next.js Bundle Analysis for @10up/headless_framework

github-actions bot commented Mar 4, 2024

📦 Next.js Bundle Analysis for @10up/headless_framework

⚠️ Global Bundle Size Increased

github-actions bot commented Mar 4, 2024

📦 Next.js Bundle Analysis for @10up/headless_framework

⚠️ Global Bundle Size Increased

github-actions bot commented Mar 6, 2024

📦 Next.js Bundle Analysis for @10up/headless_framework

⚠️ Global Bundle Size Increased

lucymtc Mar 9, 2024 • edited by nicholasio Loading

Choose a reason for hiding this comment

nicholasio Mar 9, 2024

Choose a reason for hiding this comment

nicholasio Mar 9, 2024

Choose a reason for hiding this comment

github-actions bot commented Mar 9, 2024

📦 Next.js Bundle Analysis for @10up/headless_framework

⚠️ Global Bundle Size Increased

github-actions bot commented Mar 9, 2024

📦 Next.js Bundle Analysis for @10up/headless_framework

⚠️ Global Bundle Size Increased

github-actions bot commented Mar 9, 2024

📦 Next.js Bundle Analysis for @10up/headless_framework

⚠️ Global Bundle Size Increased

github-actions bot commented Mar 9, 2024

📦 Next.js Bundle Analysis for @10up/headless_framework

⚠️ Global Bundle Size Increased

github-actions bot commented Mar 10, 2024

📦 Next.js Bundle Analysis for @10up/headless_framework

⚠️ Global Bundle Size Increased

lucymtc left a comment

Choose a reason for hiding this comment

github-actions bot commented Mar 11, 2024

📦 Next.js Bundle Analysis for @10up/headless_framework

⚠️ Global Bundle Size Increased

nicholasio commented Mar 1, 2024 •

edited

Loading

changeset-bot bot commented Mar 1, 2024 •

edited

Loading

vercel bot commented Mar 1, 2024 •

edited

Loading

lucymtc Mar 9, 2024 •

edited by nicholasio

Loading