Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove Tweener (fix for GNOME 3.38) #245

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

Remove Tweener (fix for GNOME 3.38) #245

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
27 changes: 14 additions & 13 deletions [email protected]/extension.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -33,7 +33,6 @@ const Shell = imports.gi.Shell;

const Main = imports.ui.main;
const ModalDialog = imports.ui.modalDialog;
const Tweener = imports.ui.tweener;

const _ = Gettext.gettext;
const Config = imports.misc.config;
Expand Down Expand Up @@ -436,22 +435,23 @@ const DropDownTerminalExtension = new Lang.Class({
break;
}

Tweener.addTween(this._windowActor, {
this._windowActor.ease({
x: targetX,
y: targetY,
opacity: 0,
time: animationTime,
transition: "easeInExpo",
transition: Clutter.AnimationMode.EASE_OUT_QUAD,
onUpdate: Lang.bind(this, this._updateClip),
onComplete: Lang.bind(this, function() {
// unregisters the ctrl-alt-tab group
Main.ctrlAltTabManager.removeGroup(this._windowActor);
// unregisters the ctrl-alt-tab group
Main.ctrlAltTabManager.removeGroup(this._windowActor);

// clears the window actor ref since we use it to know the window visibility
this._windowActor = null;
// clears the window actor ref since we use it to know the window visibility
this._windowActor = null;

// requests toggling asynchronously
this._busProxy.ToggleRemote();
})
// requests toggling asynchronously
this._busProxy.ToggleRemote();
})
});
} else {
this._busProxy.ToggleRemote();
Expand Down Expand Up @@ -646,13 +646,14 @@ const DropDownTerminalExtension = new Lang.Class({
break;
}

Tweener.addTween(this._windowActor, {
this._windowActor.ease({
y: this._windowY,
x: this._windowX,
onUpdate: Lang.bind(this, this._updateClip),
scale_y: 1.0,
opacity: 255,
time: this._openingAnimationTimeMillis / 1000.0,
transition: "easeOutExpo",
transition: Clutter.AnimationMode.EASE_IN_QUAD,
onUpdate: Lang.bind(this, this._updateClip),
onComplete: completeOpening
});
}));
Expand Down