Changes from code review

zytedata · Aug 26, 2024 · 12cb8ef · 12cb8ef
1 parent d625705
commit 12cb8ef
Show file tree

Hide file tree

Showing 2 changed files with 5 additions and 7 deletions.
diff --git a/tests/test_processors.py b/tests/test_processors.py
@@ -136,7 +136,9 @@ def breadcrumbs(self):
     [
         (None, None),
         ("", None),
+        (" ", None),
         ("foo", Brand(name="foo")),
+        (" foo ", Brand(name="foo")),
         (Selector(text="<html></html>"), None),
         (SelectorList([]), None),
         (fromstring("<p>foo</p>"), Brand(name="foo")),
@@ -401,6 +403,8 @@ def images(self):
         ({}, {}),
         (22.9, "22.90"),
         (22.0, "22.00"),
+        ("22.9", "22.9"),
+        ("Do not apply to strings...", "Do not apply to strings..."),
     ],
 )
 def test_prices(input_value, expected_value):

diff --git a/zyte_common_items/processors.py b/zyte_common_items/processors.py
@@ -121,6 +121,7 @@ def brand_processor(value: Any, page: Any) -> Any:
     value = _handle_selectorlist(value)
 
     if isinstance(value, str):
+        value = value.strip()
         return Brand(name=value) if value else None
 
     if isinstance(value, (Selector, SelectorList, HtmlElement)):
@@ -373,13 +374,6 @@ def images_processor(value: Any, page: Any) -> Any:
     Other inputs are returned unchanged.
     """
 
-    # TODO: add generic-purpose extract_images utility to zyte-parsers
-    #
-    # value = _handle_selectorlist(value)
-    # if isinstance(value, (Selector, HtmlElement)):
-    #    images = extract_images(value)
-    #    return [Image(url=url) for url in images]
-
     if isinstance(value, str):
         return [Image(url=value)]