Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

CMake: don't unconditionally compile Segment.{h,c} #516

Merged
merged 1 commit into from
Jul 10, 2024
Merged

CMake: don't unconditionally compile Segment.{h,c} #516

merged 1 commit into from
Jul 10, 2024

Conversation

athre0z
Copy link
Member

@athre0z athre0z commented Jul 10, 2024

As pointed out by @korli here, we previously accidentally compiled Segment.h / Segment.c regardless of whether ZYDIS_FEATURE_SEGMENT was enabled or not.

@athre0z athre0z added C-bug Category: This is a bug (or a fix for a bug, when applied to PRs) A-build Area: Build system labels Jul 10, 2024
@athre0z athre0z self-assigned this Jul 10, 2024
@athre0z athre0z marked this pull request as ready for review July 10, 2024 17:54
@athre0z athre0z requested a review from flobernd July 10, 2024 17:55
flobernd
flobernd approved these changes Jul 10, 2024
View reviewed changes
Copy link
Member

@flobernd flobernd left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@athre0z athre0z merged commit 16c6a36 into master Jul 10, 2024
13 checks passed
@athre0z athre0z deleted the dont-compile-segment-c branch July 10, 2024 18:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@flobernd flobernd flobernd approved these changes

Assignees

@athre0z athre0z

Labels
A-build Area: Build system C-bug Category: This is a bug (or a fix for a bug, when applied to PRs)
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@athre0z @flobernd