-
-
Notifications
You must be signed in to change notification settings - Fork 49
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add meson build system support #75
Conversation
I plan to add this to Zydis soon. If this is acceptable, I will start working on it! |
Hey and thank you for the PR! :) I'm afraid that having a second build system may be quite a bit of a maintenance burden in the long run. I personally also don't have any experience with Meson at all, and to my knowledge neither does @flobernd. The only way that I see us accepting this would be if you were to volunteer to maintain it and help out whenever there are issues with it. Would that be a responsibility that you'd be willing to take? |
Yes! I currently use this in my downstream project, and I'm patching Zydis to support my usage (it was a burden). I'd like to take this responsibility. |
02afd6b
to
b173824
Compare
Please re-run the CI tasks. GitHub Actions had an outage earlier this day. |
Working on windows support for the meson CI. Should I also add a MinGW-w64 gcc test for meson? |
All CI tests are passing 😁 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM. Thank you for all the work on that! :)
great, i can start refining the zydis one :D |
No description provided.