Skip to content

Commit

Permalink
Bump actions/setup-python from 5.1.0 to 5.1.1 (#126)
Browse files Browse the repository at this point in the history
Add shim for changed validation error message: django/django@31837db
  • Loading branch information
jieter authored Jul 23, 2024
1 parent 803e5d1 commit d6e22af
Show file tree
Hide file tree
Showing 2 changed files with 12 additions and 9 deletions.
10 changes: 5 additions & 5 deletions .github/workflows/ci.yml
Original file line number Diff line number Diff line change
Expand Up @@ -4,7 +4,7 @@ jobs:
black:
runs-on: ubuntu-latest
steps:
- uses: actions/[email protected].0
- uses: actions/[email protected].1
with:
python-version: "3.11"
- uses: actions/checkout@v4
Expand All @@ -14,7 +14,7 @@ jobs:
flake8:
runs-on: ubuntu-latest
steps:
- uses: actions/[email protected].0
- uses: actions/[email protected].1
with:
python-version: "3.11"
- uses: actions/checkout@v4
Expand All @@ -24,7 +24,7 @@ jobs:
isort:
runs-on: ubuntu-latest
steps:
- uses: actions/[email protected].0
- uses: actions/[email protected].1
with:
python-version: "3.11"
- uses: actions/checkout@v4
Expand All @@ -34,7 +34,7 @@ jobs:
docs:
runs-on: ubuntu-latest
steps:
- uses: actions/[email protected].0
- uses: actions/[email protected].1
- uses: actions/checkout@v4
- run: python -m pip install -r docs/requirements.txt
- run: cd docs/ && make html && make spelling
Expand Down Expand Up @@ -88,7 +88,7 @@ jobs:
- 5432:5432
steps:
- name: Set up Python ${{ matrix.python-version }}
uses: actions/[email protected].0
uses: actions/[email protected].1
with:
python-version: ${{ matrix.python-version }}
- uses: actions/checkout@v4
Expand Down
11 changes: 7 additions & 4 deletions tests/test_translating.py
Original file line number Diff line number Diff line change
@@ -1,3 +1,4 @@
import django
from django.core.exceptions import ImproperlyConfigured, ValidationError
from django.db import models
from django.test import TestCase
Expand Down Expand Up @@ -289,9 +290,11 @@ def test_limit_choices_to(self):
comment = app_models.Comment.objects.create(post=published_post, text="foo")
self.assertIsNotNone(comment.pk)

with self.assertRaisesMessage(
ValidationError,
f"post instance with id {unpublished_post.pk} does not exist",
):
if django.get_version().startswith("5.2"):
expected = f"post instance with id {unpublished_post.pk} is not a valid choice."
else:
expected = f"post instance with id {unpublished_post.pk} does not exist"

with self.assertRaisesMessage(ValidationError, expected):
comment.post = unpublished_post
comment.full_clean()

0 comments on commit d6e22af

Please sign in to comment.