Skip to content

Commit

Permalink
reduce test verbosity; remove duplicate require
Browse files Browse the repository at this point in the history
  • Loading branch information
pcai committed Sep 30, 2024
1 parent fa85535 commit 35f9717
Show file tree
Hide file tree
Showing 3 changed files with 1 addition and 4 deletions.
1 change: 1 addition & 0 deletions CHANGELOG.md
Original file line number Diff line number Diff line change
Expand Up @@ -7,6 +7,7 @@
- Test Rails 7.1 and 7.2 (https://github.com/zombocom/derailed_benchmarks/pull/242)
- Switch from dead_end to syntax_suggest (https://github.com/zombocom/derailed_benchmarks/pull/243)
- require `ruby2_keywords` so drb doesn't break in ruby < 2.7 (https://github.com/zombocom/derailed_benchmarks/pull/244)
- support relative BUNDLE_GEMFILE in tests (https://github.com/zombocom/derailed_benchmarks/pull/245)

## 2.1.2

Expand Down
2 changes: 0 additions & 2 deletions test/integration/tasks_test.rb
Original file line number Diff line number Diff line change
Expand Up @@ -14,7 +14,6 @@ def teardown
end

def run!(cmd)
puts "Running: #{cmd}"
out = `#{cmd}`
raise "Could not run #{cmd}, output: #{out}" unless $?.success?
out
Expand All @@ -25,7 +24,6 @@ def rake(cmd, options = {})
env = options[:env] || {}
env_string = env.map {|key, value| "#{key.shellescape}=#{value.to_s.shellescape}" }.join(" ")
cmd = "env #{env_string} bundle exec rake -f perf.rake #{cmd} --trace"
puts "Running: #{cmd}"
result = Bundler.with_original_env do
# Ensure relative BUNDLE_GEMFILE is expanded so path is still correct after cd
ENV['BUNDLE_GEMFILE'] = File.expand_path(ENV['BUNDLE_GEMFILE']) if ENV['BUNDLE_GEMFILE']
Expand Down
2 changes: 0 additions & 2 deletions test/test_helper.rb
Original file line number Diff line number Diff line change
Expand Up @@ -6,7 +6,6 @@
# Configure Rails Envinronment
ENV["RAILS_ENV"] = "test"


require "ruby2_keywords" if RUBY_VERSION < "2.7"

require 'rails'
Expand All @@ -18,7 +17,6 @@
require 'derailed_benchmarks'

require File.expand_path("../rails_app/config/environment.rb", __FILE__)
require "rails/test_help"

ActionMailer::Base.delivery_method = :test
ActionMailer::Base.perform_deliveries = true
Expand Down

0 comments on commit 35f9717

Please sign in to comment.