This repository has been archived by the owner on Jun 12, 2024. It is now read-only.
Fix for issue #431: Not all records are exported when calling DataGrid::buildCSV() #432
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…aGrid::buildCSV()
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
As the title says, fix for issue #431.
This also has a significant yet simple performance improvement to the loop gathering the data/rows from
$this->sourcefor the PDOStatement on lines 212:215 of DataSet::build(), by simply getting out of the loop as soon as all required records have been collected. My mistake for not including this in my initial PR.Note: I am working on #430, but it is probably better and easier to understand if the PR's are kept to small units.
Cheers.
/s