Skip to content
This repository has been archived by the owner on Jun 12, 2024. It is now read-only.

Not all records are exported when calling DataGrid::buildCSV() #431

Open
sroutier opened this issue May 7, 2018 · 0 comments
Open

Not all records are exported when calling DataGrid::buildCSV() #431

sroutier opened this issue May 7, 2018 · 0 comments

Comments

@sroutier
Copy link
Contributor

sroutier commented May 7, 2018

In DataGrid::buildCSV() the limit is set to null prior to calling parent::build():

...
    public function buildCSV($file = '', $timestamp = '', $sanitize = true,$del = array())
    {
        $this->limit = null;
        parent::build();
...

But in (the parent) DataSet::build() on line 186 and 229 for the section about PDOStatement and Arrays the limit is overwritten to be set to 10000:

...
                $limit = $this->limit ? $this->limit : 100000;
...

I have a fix on it's way.

@sroutier sroutier changed the title Not all records are exported when calling DataGrid::BuildCSV() Not all records are exported when calling DataGrid::buildCSV() May 7, 2018
sroutier added a commit to sroutier/rapyd-laravel that referenced this issue May 7, 2018
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant